Fix for #63 - null values in FK field

Author: JohannesJander

pom.xml

@@ -4,7 +4,7 @@
     <modelVersion>4.0.0</modelVersion>
     <groupId>io.frictionlessdata</groupId>
     <artifactId>datapackage-java</artifactId>
-    <version>0.9.7-SNAPSHOT</version>
+    <version>0.9.8-SNAPSHOT</version>
     <packaging>jar</packaging>
     <issueManagement>
         <url>https://github.com/frictionlessdata/datapackage-java/issues</url>
@@ -17,13 +17,13 @@
     </scm>
 
     <properties>
-        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>Fix
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <java.version>17</java.version>
         <maven.compiler.source>${java.version}</maven.compiler.source>
         <maven.compiler.target>${java.version}</maven.compiler.target>
         <maven.compiler.compiler>${java.version}</maven.compiler.compiler>
-        <tableschema-java-version>0.9.6</tableschema-java-version>
+        <tableschema-java-version>0.9.8</tableschema-java-version>
         <junit.version>5.13.4</junit.version>
         <slf4j-simple.version>2.0.17</slf4j-simple.version>
         <apache-commons-collections4.version>4.5.0</apache-commons-collections4.version>

src/test/java/io/frictionlessdata/datapackage/ForeignKeysTest.java renamed to src/test/java/io/frictionlessdata/datapackage/fk/ForeignKeyTest.java

@@ -1,5 +1,7 @@
-package io.frictionlessdata.datapackage;
+package io.frictionlessdata.datapackage.fk;
 
+import io.frictionlessdata.datapackage.Package;
+import io.frictionlessdata.datapackage.TestUtil;
 import io.frictionlessdata.datapackage.exceptions.DataPackageValidationException;
 import io.frictionlessdata.datapackage.resource.Resource;
 import io.frictionlessdata.tableschema.exception.ForeignKeyException;
@@ -8,24 +10,26 @@
 import org.junit.jupiter.api.Test;
 
 import java.nio.file.Path;
+import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class ForeignKeysTest {
+public class ForeignKeyTest {
 
     @Test
     @DisplayName("Test that foreign keys are validated correctly, good case")
     void testForeignKeysGoodCase() throws Exception{
         Path resourcePath = TestUtil.getResourcePath("/fixtures/datapackages/foreign_keys_valid.json");
-        Package pkg = new Package(resourcePath, true);
-        pkg.getResource("teams");
+        io.frictionlessdata.datapackage.Package pkg = new io.frictionlessdata.datapackage.Package(resourcePath, true);
+        Resource teams = pkg.getResource("teams");
+        teams.checkRelations(pkg);
     }
 
     @Test
     @DisplayName("Test that foreign keys are validated correctly, bad case")
     void testForeignKeysBadCase() throws Exception{
         Path resourcePath = TestUtil.getResourcePath("/fixtures/datapackages/foreign_keys_invalid.json");
-        Package pkg = new Package(resourcePath, true);
+        io.frictionlessdata.datapackage.Package pkg = new Package(resourcePath, true);
         Resource teams = pkg.getResource("teams");
 
         DataPackageValidationException ex = assertThrows(DataPackageValidationException.class,
@@ -34,4 +38,17 @@ void testForeignKeysBadCase() throws Exception{
         Assertions.assertInstanceOf(ForeignKeyException.class, cause);
         Assertions.assertEquals("Foreign key validation failed: [city] -> [name]: 'Munich' not found in resource 'cities'.", cause.getMessage());
     }
+
+    @Test
+    @DisplayName("Test checkRelations on valid resources in different-valid-data-formats datapackage")
+    void testCheckRelationsOnAllResources() throws Exception {
+        Path resourcePath = TestUtil.getResourcePath("/fixtures/datapackages/different-valid-data-formats/datapackage.json");
+        Package dp = new Package(resourcePath, true);
+
+        dp.getResource("teams_with_headers_csv_file").checkRelations(dp);
+        dp.getResource("teams_arrays_inline").checkRelations(dp);
+        dp.getResource("teams_objects_inline").checkRelations(dp);
+        dp.getResource("teams_arrays_file").checkRelations(dp);
+        dp.getResource("teams_objects_file").checkRelations(dp);
+    }
 }

src/test/resources/fixtures/datapackages/foreign_keys_valid.json

@@ -23,6 +23,11 @@
           "3",
           "Bayern",
           "Munich"
+        ],
+        [
+          "4",
+          "MadeUpFC",
+          null
         ]
       ],
       "schema": {