Maintenance release, added spotbugs maven plugin

Author: JohannesJander

pom.xml

@@ -168,6 +168,24 @@
                     </execution>
                 </executions>
             </plugin>
+
+            <plugin>
+                <groupId>com.github.spotbugs</groupId>
+                <artifactId>spotbugs-maven-plugin</artifactId>
+                <version>4.9.3.0</version>
+                <configuration>
+                    <effort>Max</effort>
+                    <threshold>High</threshold>
+                    <xmlOutput>false</xmlOutput>
+                </configuration>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
         </plugins>
     </build>
 

src/main/java/io/frictionlessdata/tableschema/Table.java

@@ -20,6 +20,8 @@
 
 import java.io.*;
 import java.net.URL;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
 import java.util.*;
 
 /**
@@ -54,6 +56,8 @@ public class Table{
     private Schema schema = null;
     private CSVFormat format = TableDataSource.getDefaultCsvFormat();
 
+    private Charset charset = StandardCharsets.UTF_8;
+
     /**
      * Constructor for an empty Table. It contains neither data nor is it controlled by a Schema
      */
@@ -327,6 +331,22 @@ public Iterator<Map<String, Object>> mappingIterator(boolean extended, boolean c
         return new TableIterator<>(this, true, extended, cast, relations);
     }
 
+    /**
+     * returns the charset or encoding to use when writing CSV files.
+     * @return the used charset
+     */
+    public Charset getCharset() {
+        return charset;
+    }
+
+    /**
+     * Sets the charset or encoding to use when writing CSV files.
+     * @param charset the charset to use
+     */
+    public void setCharset(Charset charset) {
+        this.charset = charset;
+    }
+
     public Map<Integer, Integer> getSchemaHeaderMapping() {
         if (null == schema) {
             return TableSchemaUtil
@@ -562,7 +582,7 @@ public void writeCsv(Writer out, CSVFormat format) {
      * @param format the CSV format to use
      */
     public void writeCsv(File outputFile, CSVFormat format){
-        try (FileWriter fw = new FileWriter(outputFile)) {
+        try (FileWriter fw = new FileWriter(outputFile, charset)) {
             writeCsv(fw, format);
         } catch (IOException ex) {
             throw new TableIOException(ex);

src/main/java/io/frictionlessdata/tableschema/field/Field.java

@@ -570,23 +570,23 @@ public String getTitle(){
         return this.title;
     }
 
-  public void setTitle(String title) {
+    public void setTitle(String title) {
     this.title = title;
   }
 
     public String getDescription(){
         return this.description;
     }
 
-  public void setDescription(String description) {
+    public void setDescription(String description) {
     this.description = description;
   }
 
     public Map<String, Object> getConstraints(){
         return this.constraints;
     }
 
-  public void setConstraints(Map<String, Object> constraints) {
+    public void setConstraints(Map<String, Object> constraints) {
     this.constraints = constraints;
   }
 

src/main/java/io/frictionlessdata/tableschema/field/StringField.java

@@ -7,6 +7,8 @@
 
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 import java.util.Map;
 import java.util.regex.Matcher;
@@ -61,7 +63,7 @@ public String formatValueAsString(String value, String format, Map<String, Objec
     String formatObjectValueAsString(Object value, String format, Map<String, Object> options) throws InvalidCastException, ConstraintsException {
         if (value instanceof byte[]) {
             byte[] encode = Base64.getEncoder().encode((byte[]) value);
-            String retVal = new String(encode);
+            String retVal = new String(encode, StandardCharsets.UTF_8);
             return retVal;
         }
         return value.toString();

src/main/java/io/frictionlessdata/tableschema/fk/ForeignKey.java

@@ -27,7 +27,7 @@ public class ForeignKey {
 
     public ForeignKey(){}
 
-    public ForeignKey(Object fields, Reference reference, boolean strict) throws ForeignKeyException{
+    public ForeignKey(Object fields, Reference reference, boolean strict) {
         this.fields = fields;
         this.reference = reference;
         this.strictValidation = strict;

src/main/java/io/frictionlessdata/tableschema/fk/Reference.java

@@ -36,7 +36,7 @@ public class Reference {
 
     public Reference(){}
 
-    public Reference(String resource, Object fields, boolean strict) throws ForeignKeyException{
+    public Reference(String resource, Object fields, boolean strict) {
         this.resourceName = resource;
         this.fields = fields;
         this.strictValidation = strict;

src/main/java/io/frictionlessdata/tableschema/schema/Schema.java

@@ -20,6 +20,7 @@
 
 import java.io.*;
 import java.net.URL;
+import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
 import java.util.*;
 import java.util.stream.Collectors;
@@ -53,6 +54,11 @@ public class Schema implements SchemaInterface{
     public static final String JSON_KEY_PRIMARY_KEY = "primaryKey";
     public static final String JSON_KEY_FOREIGN_KEYS = "foreignKeys";
 
+    /**
+     * The charset or encoding of the schema
+     */
+    private Charset charset = StandardCharsets.UTF_8;
+
     // the schema validator
     @JsonIgnore
     private FormalSchemaValidator tableFormalSchemaValidator = null;
@@ -244,7 +250,7 @@ public void writeJson(File outputFile) throws IOException {
     }
 
     private void writeJson(OutputStream output) throws IOException {
-        try (BufferedWriter file = new BufferedWriter(new OutputStreamWriter(output))) {
+        try (BufferedWriter file = new BufferedWriter(new OutputStreamWriter(output, charset))) {
             file.write(this.asJson());
         }
     }