feat: Update validation error to include original value

Prior, the validation error may contain the cast-value which can be confusing when reporting the validation error to users.

Author: courtney-miles

Dockerfile

@@ -1,4 +1,4 @@
-FROM php:8.2-cli
+FROM php:8.1-cli
 
 RUN apt-get update -y
 

docker-compose.yml

@@ -4,3 +4,4 @@ services:
         volumes:
             - .:/src
         command: bash
+        network_mode: host

src/Fields/BaseField.php

@@ -171,6 +171,12 @@ public function validateValue($val)
 
             return [];
         } catch (FieldValidationException $e) {
+            foreach ($e->validationErrors as $ve) {
+                // Replace the cast-value for the violation, with the original value.
+                // This so the error message contains the original representation of the invalid value.
+                $ve->extraDetails['value'] = $val;
+            }
+
             return $e->validationErrors;
         }
     }

tests/FieldTest.php

@@ -475,12 +475,12 @@ public static function provideInvalidDataForConstraint(): array
     {
         return [
             ['name: value does not match pattern ("123")', 'string', ['pattern' => '3.*'], '123'],
-            ['name: value not in enum (4)', 'integer', ['enum' => ['1', '2', 3]], '4'],
+            ['name: value not in enum ("4")', 'integer', ['enum' => ['1', '2', 3]], '4'],
             ['name: value not in enum (4)', 'integer', ['enum' => ['1', '2', 3]], 4],
             ['name: value is below minimum (0)', 'integer', ['minimum' => 1], 0],
-            ['name: value is below minimum (0)', 'integer', ['minimum' => 1], '0'],
+            ['name: value is below minimum ("0")', 'integer', ['minimum' => 1], '0'],
             ['name: value is above maximum (2)', 'integer', ['maximum' => 1], 2],
-            ['name: value is above maximum (2)', 'integer', ['maximum' => 1], '2'],
+            ['name: value is above maximum ("2")', 'integer', ['maximum' => 1], '2'],
             ['name: value is below minimum length ("a")', 'string', ['minLength' => 2], 'a'],
             ['name: value is above maximum length ("aaa")', 'string', ['maxLength' => 2], 'aaa'],
         ];

tests/Fields/BaseFieldTest.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Fields;
+
+use frictionlessdata\tableschema\Fields\BaseField;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \frictionlessdata\tableschema\Fields\BaseField
+ */
+class BaseFieldTest extends TestCase
+{
+    public function testPreserveOriginalValueInValidationError(): void
+    {
+        $descriptor = (object) [
+            'name' => 'date_col',
+            'constraints' => (object) ['minimum' => '2025-07-01'],
+        ];
+
+        $sut = new class($descriptor) extends BaseField {
+            protected function validateCastValue($val)
+            {
+                // If the logic is wrong, this object will be in the error
+                // instead of the original date string.
+                return new \DateTimeImmutable($val);
+            }
+        };
+
+        $validatedValue = '2025-06-30';
+        $errors = $sut->validateValue($validatedValue);
+
+        self::assertCount(1, $errors);
+        $error = reset($errors);
+        self::assertSame(
+            $validatedValue,
+            $error->extraDetails['value']
+        );
+    }
+}