Add Github CI with custom action

Author: mamhoff

.github/workflows/ci.yml

@@ -0,0 +1,10 @@
+on: [push]
+
+jobs:
+  run_tests:
+    runs-on: ubuntu-22.04
+    name: Run tests on ...
+    steps:
+      - uses: actions/checkout@v4
+      - id: foo
+        uses: friendlycart/action-solidus-extension@main

Gemfile

@@ -1,23 +1,23 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
-branch = ENV.fetch('SOLIDUS_BRANCH', 'v3.2')
-gem 'solidus', github: 'solidusio/solidus', branch: branch
+branch = ENV.fetch("SOLIDUS_BRANCH", "v3.2")
+gem "solidus", github: "solidusio/solidus", branch: branch
 
 # Needed to help Bundler figure out how to resolve dependencies,
 # otherwise it takes forever to resolve them.
 # See https://github.com/bundler/bundler/issues/6677
-gem 'rails', ENV.fetch('RAILS_VERSION', '>0.a')
+gem "rails", ENV.fetch("RAILS_VERSION", ">0.a")
 
-case ENV['DB']
-when 'mysql'
-  gem 'mysql2'
-when 'postgresql'
-  gem 'pg'
+case ENV["DB"]
+when "mysql"
+  gem "mysql2"
+when "postgresql"
+  gem "pg"
 else
-  gem 'sqlite3', "~> 1.7"
+  gem "sqlite3", "~> 1.7"
 end
 
 gemspec
@@ -27,10 +27,11 @@ gemspec
 #
 # We use `send` instead of calling `eval_gemfile` to work around an issue with
 # how Dependabot parses projects: https://github.com/dependabot/dependabot-core/issues/1658.
-send(:eval_gemfile, 'Gemfile-local') if File.exist? 'Gemfile-local'
+send(:eval_gemfile, "Gemfile-local") if File.exist? "Gemfile-local"
 
 group :test do
-  gem 'shoulda-matchers', '~> 4.0'
+  gem "shoulda-matchers", "~> 4.0"
+  gem "standardrb"
 end
 
 gem "concurrent-ruby", "< 1.3.5"

Rakefile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'solidus_dev_support/rake_tasks'
+require "solidus_dev_support/rake_tasks"
 SolidusDevSupport::RakeTasks.install
 
-task default: 'extension:specs'
+task default: "extension:specs"

app/controllers/solidus_configurable_kits/admin/kit_requirements_controller.rb

@@ -3,9 +3,10 @@
 module SolidusConfigurableKits
   module Admin
     class KitRequirementsController < ::Spree::Admin::ResourceController
-      belongs_to 'spree/product', find_by: :slug
+      belongs_to "spree/product", find_by: :slug
 
-      def index; end
+      def index
+      end
 
       private
 

app/controllers/solidus_configurable_kits/orders_controller.rb

@@ -2,7 +2,7 @@
 
 module SolidusConfigurableKits
   class OrdersController < ::Spree::StoreController
-    helper 'spree/products', 'spree/orders'
+    helper "spree/products", "spree/orders"
 
     respond_to :html
 
@@ -14,13 +14,13 @@ def populate_kit
       @order = current_order(create_order_if_necessary: true)
       authorize! :update, @order, cookies.signed[:guest_token]
 
-      variant  = ::Spree::Variant.find(params[:variant_id])
+      variant = ::Spree::Variant.find(params[:variant_id])
       quantity = params[:quantity].present? ? params[:quantity].to_i : 1
-      options = { kit_variant_ids: params[:kit_variant_ids] }
+      options = {kit_variant_ids: params[:kit_variant_ids]}
 
       # 2,147,483,647 is crazy. See issue https://github.com/spree/spree/issues/2695.
       if !quantity.between?(1, 2_147_483_647)
-        @order.errors.add(:base, t('spree.please_enter_reasonable_quantity'))
+        @order.errors.add(:base, t("spree.please_enter_reasonable_quantity"))
       else
         begin
           @line_item = @order.contents.add(variant, quantity, options)

app/decorators/controllers/solidus_configurable_kits/spree/api/variants_controller_decorator.rb

@@ -8,13 +8,13 @@ module VariantsControllerDecorator
 
         def include_list
           list = [
-            { option_values: :option_type },
-            { product: :kit_requirements },
+            {option_values: :option_type},
+            {product: :kit_requirements},
             #             :default_price,
             :images,
-            { stock_items: :stock_location },
+            {stock_items: :stock_location}
           ]
-          list.push(:default_price) if ::Spree.solidus_gem_version < Gem::Version.new('3')
+          list.push(:default_price) if ::Spree.solidus_gem_version < Gem::Version.new("3")
           list
         end
 

app/decorators/models/solidus_configurable_kits/spree/product_decorator.rb

@@ -12,7 +12,7 @@ def self.prepended(base)
         base.delegate :resilient_money_price, to: :master
 
         base.scope :with_kit_item_prices, -> {
-          joins(variants_including_master: :prices).where(spree_prices: { kit_item: true }).distinct
+          joins(variants_including_master: :prices).where(spree_prices: {kit_item: true}).distinct
         }
       end
 
@@ -21,7 +21,7 @@ def self.prepended(base)
       # @return [Array<Spree::Variant>] all variants that can be part of a kit
       def kit_item_variants_for(pricing_options = Spree::Config.default_pricing_options)
         variants_including_master.includes(:option_values).with_prices(pricing_options).select do |variant|
-          variant.option_values.any? || (variant.is_master? && variants.none? )
+          variant.option_values.any? || (variant.is_master? && variants.none?)
         end
       end
 

app/decorators/models/solidus_configurable_kits/spree/variant_decorator.rb

@@ -11,17 +11,17 @@ def with_prices(pricing_options = ::Spree::Config.default_pricing_options)
               (spree_prices.country_iso IS NULL OR spree_prices.country_iso = ?)
           SQL
           where(
-            ::Spree::Price.
-              where(::Spree::Variant.arel_table[:id].eq(::Spree::Price.arel_table[:variant_id])).
+            ::Spree::Price
+              .where(::Spree::Variant.arel_table[:id].eq(::Spree::Price.arel_table[:variant_id])).
               # This next clause should just be `where(pricing_options.search_arguments)`, but ActiveRecord
               # generates invalid SQL, so the SQL here is written manually.
               where(
                 query,
                 pricing_options.search_arguments[:currency],
                 pricing_options.search_arguments[:kit_item],
                 pricing_options.search_arguments[:country_iso].compact
-              ).
-              arel.exists
+              )
+              .arel.exists
           )
         end
       end

app/models/solidus_configurable_kits/shipping_manifest.rb

@@ -7,7 +7,7 @@ def items
       kit_manifest_items = grouped_by_kit.keys.compact
       result = []
       kit_manifest_items.each do |kit_line_item|
-        result += [grouped_by_kit[nil].detect{ |i| i.line_item = kit_line_item }]
+        result += [grouped_by_kit[nil].detect { |i| i.line_item = kit_line_item }]
         result += grouped_by_kit[kit_line_item]
       end
       result += grouped_by_kit[nil]&.reject { |manifest_item| manifest_item.line_item.kit? } || []

app/services/solidus_configurable_kits/price_selector.rb

@@ -27,7 +27,7 @@ def price_for_options(price_options)
         (price.country_iso == price_options.desired_attributes[:country_iso] ||
           price.country_iso.nil?
         ) && price.currency == price_options.desired_attributes[:currency] &&
-        price.kit_item == price_options.desired_attributes[:kit_item]
+          price.kit_item == price_options.desired_attributes[:kit_item]
       end
     end
   end