Skip to content

Commit d8287ea

Browse files
committed
Adapt gopherAPI to use Zipkin
1 parent e537ff4 commit d8287ea

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

pkg/server/server_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111

1212
"github.com/friendsofgo/gopherapi/pkg/log"
1313
"github.com/friendsofgo/gopherapi/pkg/removing"
14+
"github.com/friendsofgo/gopherapi/pkg/tracer"
1415

1516
"github.com/friendsofgo/gopherapi/pkg/adding"
1617
"github.com/friendsofgo/gopherapi/pkg/fetching"
@@ -185,11 +186,13 @@ func gopherSample() *gopher.Gopher {
185186
}
186187

187188
func buildServer() Server {
188-
repo := inmem.NewRepository(sample.Gophers)
189+
190+
noopTracer := tracer.NewNoopTracer()
191+
repo := inmem.NewRepository(sample.Gophers, tracer.NewNoopTracer())
189192
fS := fetching.NewService(repo, log.NewNoopLogger())
190193
aS := adding.NewService(repo)
191194
mS := modifying.NewService(repo)
192195
rS := removing.NewService(repo)
193196

194-
return New("test", fS, aS, mS, rS)
197+
return New("test", noopTracer, fS, aS, mS, rS)
195198
}

pkg/tracer/tracer.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,9 @@ func NewTracer(serviceName string, reporterURL string) (*zipkin.Tracer, error) {
3333
}
3434
return t, nil
3535
}
36+
37+
// NewNoopTracer creates a new no operational tracer with the necessary dependencies
38+
func NewNoopTracer() *zipkin.Tracer {
39+
noopTracer, _ := zipkin.NewTracer(nil)
40+
return noopTracer
41+
}

0 commit comments

Comments
 (0)