Skip to content

Clarify Directions to Dynamically Include libgit2 #3821

@merichar

Description

@merichar

Problem

The current comment in phoenix.pro says:

# Disable this if you have (and want) libgit2 dynamically
LIBGIT_STATIC = true

It's ambiguous and some folks are going to comment this out instead of setting it to false, which leads to the qmake error:

libgit2detect.pri:22: if(condition) requires one argument.

Proposed Solution

To save other folks some time, let's just rephrase it to:

# Set this to false if you have (and want) libgit2 dynamically
LIBGIT_STATIC = true

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions