Fix cross-origin iframe bug. Fixes #46

Author: fritz-c

src/react-image-lightbox.js

@@ -10,7 +10,7 @@ import {
     translate,
     getWindowWidth,
     getWindowHeight,
-    isInIframe,
+    isInSameOriginIframe,
     getIEVersion,
 } from './util';
 import {
@@ -239,7 +239,7 @@ class ReactImageLightbox extends Component {
             window.addEventListener('pointercancel', this.handlePointerEvent);
             // Have to add an extra mouseup handler to catch mouseup events outside of the window
             //  if the page containing the lightbox is displayed in an iframe
-            if (isInIframe()) {
+            if (isInSameOriginIframe()) {
                 window.top.addEventListener('mouseup', this.handleMouseUp);
                 window.top.addEventListener('touchend', this.handleTouchEnd);
                 window.top.addEventListener('touchcancel', this.handleTouchEnd);
@@ -351,7 +351,7 @@ class ReactImageLightbox extends Component {
             window.removeEventListener('pointermove', this.handlePointerEvent);
             window.removeEventListener('pointerup', this.handlePointerEvent);
             window.removeEventListener('pointercancel', this.handlePointerEvent);
-            if (isInIframe()) {
+            if (isInSameOriginIframe()) {
                 window.top.removeEventListener('mouseup', this.handleMouseUp);
                 window.top.removeEventListener('touchend', this.handleTouchEnd);
                 window.top.removeEventListener('touchcancel', this.handleTouchEnd);

src/util.js

@@ -52,10 +52,11 @@ export function getWindowHeight() {
 }
 
 // Returns true if this window is rendered as an iframe inside another window
-export function isInIframe() {
+// with the same origin.
+export function isInSameOriginIframe() {
     try {
-        return window.self !== window.top;
+        return (window.self !== window.top) && window.top.document;
     } catch (e) {
-        return true;
+        return false;
     }
 }