fix: ensure bot metadata is initialized before grid operations

Move ensureBotEntries() call to execute right after AccountOrders creation,
before any Grid initialization. This prevents new order files from being
created with null values for name, assetA, assetB.

Changes:
- bot.js: Move ensureBotEntries() to start() method before Grid operations
- dexbot.js: Add ensureBotEntries() call to start() method (was missing)
- account_orders.js: Add debug logging to trace metadata initialization
- constants.js: Set LOG_LEVEL to debug for troubleshooting

The issue occurred because storeMasterGrid() would create a new bot entry
with hardcoded null metadata if called before ensureBotEntries(). By calling
ensureBotEntries() first, we ensure the metadata is properly initialized from
the bot configuration in profiles/bots.json.

Metadata is updated at startup and persists across restarts, which is
sufficient since the bot's runtime config comes from this.config, not the
order file metadata.

Author: froooze

CHANGELOG.md

@@ -46,6 +46,12 @@ All notable changes to this project will be documented in this file.
   - Removed orphaned variable definitions
   - Cleaned up fund display logic in logFundsStatus()
 
+- **Bot Metadata Initialization**: Fixed new order files being created with null metadata
+  - Ensured `ensureBotEntries()` is called before any Grid initialization
+  - Prevents order files from having null values for name, assetA, assetB
+  - Metadata properly initialized from bot configuration in profiles/bots.json at startup
+  - Applied fix to both bot.js and dexbot.js DEXBot classes
+
 ### Migration Guide
 1. **Backup** your `profiles/orders/` directory before updating
 2. **Run migration** (if you have existing bots with pendingProceeds):

bot.js

@@ -607,6 +607,21 @@ class DEXBot {
         // Create AccountOrders with bot-specific file (one file per bot)
         this.accountOrders = new AccountOrders({ botKey: this.config.botKey });
 
+        // Ensure bot metadata is properly initialized in storage BEFORE any Grid operations
+        // This prevents new order files from being created with null values for assetA, assetB, name
+        const allBotsConfig = parseJsonWithComments(fs.readFileSync(PROFILES_BOTS_FILE, 'utf8')).bots || [];
+        const allActiveBots = allBotsConfig
+            .filter(b => b.active !== false)
+            .map((b, idx) => normalizeBotEntry(b, idx));
+
+        // DEBUG: Log what we're passing to ensureBotEntries
+        console.log(`[bot.js] DEBUG ensureBotEntries: passing ${allActiveBots.length} active bot(s):`);
+        allActiveBots.forEach(bot => {
+          console.log(`  - name=${bot.name}, assetA=${bot.assetA}, assetB=${bot.assetB}, active=${bot.active}, index=${bot.botIndex}, botKey=${bot.botKey}`);
+        });
+
+        this.accountOrders.ensureBotEntries(allActiveBots);
+
         if (!this.manager) {
             this.manager = new OrderManager(this.config || {});
             this.manager.account = this.account;
@@ -776,14 +791,6 @@ class DEXBot {
             }
         });
 
-        // Ensure entries exist for ALL active bots (prevents pruning other bots)
-        // Must be done BEFORE loading persisted grid to avoid overwriting saved grids
-        const allBotsConfig = parseJsonWithComments(fs.readFileSync(PROFILES_BOTS_FILE, 'utf8')).bots || [];
-        const allActiveBots = allBotsConfig
-            .filter(b => b.active !== false)
-            .map((b, idx) => normalizeBotEntry(b, idx));
-        this.accountOrders.ensureBotEntries(allActiveBots);
-
         const persistedGrid = this.accountOrders.loadBotGrid(this.config.botKey);
         const persistedCacheFunds = this.accountOrders.loadCacheFunds(this.config.botKey);
         const persistedBtsFeesOwed = this.accountOrders.loadBtsFeesOwed(this.config.botKey);

dexbot.js

@@ -703,10 +703,24 @@ class DEXBot {
      */
     async start(masterPassword = null) {
         await this.initialize(masterPassword);
-        
+
         // Create AccountOrders with bot-specific file (one file per bot)
         this.accountOrders = new AccountOrders({ botKey: this.config.botKey });
-        
+
+        // Ensure bot metadata is properly initialized in storage BEFORE any Grid operations
+        // This prevents new order files from being created with null values for assetA, assetB, name
+        const allBotsConfig = parseJsonWithComments(fs.readFileSync(PROFILES_BOTS_FILE, 'utf8')).bots || [];
+        // Normalize all bots first (to get correct indices), then filter to active ones
+        const allActiveBots = normalizeBotEntries(allBotsConfig)
+            .filter(b => b.active !== false);
+
+        console.log(`[dexbot.js] DEBUG ensureBotEntries: passing ${allActiveBots.length} active bot(s):`);
+        allActiveBots.forEach(bot => {
+          console.log(`  - name=${bot.name}, assetA=${bot.assetA}, assetB=${bot.assetB}, active=${bot.active}, index=${bot.botIndex}, botKey=${bot.botKey}`);
+        });
+
+        this.accountOrders.ensureBotEntries(allActiveBots);
+
         if (!this.manager) {
             this.manager = new OrderManager(this.config || {});
             // Attach account identifiers so OrderManager can fetch on-chain totals when needed

modules/account_orders.js

@@ -146,7 +146,9 @@ class AccountOrders {
     const entriesToProcess = this.botKey
       ? botEntries.filter(bot => {
           const key = bot.botKey || createBotKey(bot, botEntries.indexOf(bot));
-          return key === this.botKey;
+          const matches = key === this.botKey;
+          console.log(`[AccountOrders] per-bot filter: checking bot name=${bot.name}, key=${key}, this.botKey=${this.botKey}, matches=${matches}`);
+          return matches;
         })
       : botEntries;
 
@@ -186,9 +188,16 @@ class AccountOrders {
 
         entry.grid = entry.grid || [];
         if (this._metaChanged(entry.meta, meta)) {
+          console.log(`[AccountOrders] Metadata changed for bot ${key}: updating from old metadata to new`);
+          console.log(`  OLD: name=${entry.meta?.name}, assetA=${entry.meta?.assetA}, assetB=${entry.meta?.assetB}, active=${entry.meta?.active}`);
+          console.log(`  NEW: name=${meta.name}, assetA=${meta.assetA}, assetB=${meta.assetB}, active=${meta.active}`);
           entry.meta = { ...entry.meta, ...meta, createdAt: entry.meta?.createdAt || meta.createdAt };
           entry.lastUpdated = nowIso();
           changed = true;
+        } else {
+          console.log(`[AccountOrders] No metadata change for bot ${key} - skipping update`);
+          console.log(`  CURRENT: name=${entry.meta?.name}, assetA=${entry.meta?.assetA}, assetB=${entry.meta?.assetB}, active=${entry.meta?.active}`);
+          console.log(`  PASSED:  name=${meta.name}, assetA=${meta.assetA}, assetB=${meta.assetB}, active=${meta.active}`);
         }
       }
       bot.botKey = key;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "dexbot2",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "A sophisticated market making bot for the BitShares Decentralized Exchange (DEX), implementing optimized staggered order strategies for automated trading.",
   "main": "modules/chain_orders.js",
   "bin": {