Clarify origin in examples

Author: barryvdh

README.md

@@ -46,7 +46,7 @@ use Asm89\Stack\CorsService;
 $cors = new CorsService(array(
     'allowedHeaders'         => array('x-allowed-header', 'x-other-allowed-header'),
     'allowedMethods'         => array('DELETE', 'GET', 'POST', 'PUT'),
-    'allowedOrigins'         => array('localhost'),
+    'allowedOrigins'         => array('http://localhost'),
     'allowedOriginsPatterns' => array('/localhost:\d/'),
     'exposedHeaders'         => false,
     'maxAge'                 => false,

tests/CorsTest.php

@@ -25,11 +25,10 @@ class CorsTest extends TestCase
     public function it_does_modify_on_a_request_without_origin()
     {
         $app                = $this->createStackedApp();
-        $unmodifiedResponse = new Response();
 
         $response = $app->handle(new Request());
 
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
     }
 
     /**
@@ -59,7 +58,7 @@ public function it_returns_allow_origin_header_on_valid_actual_request()
         $response = $app->handle($request);
 
         $this->assertTrue($response->headers->has('Access-Control-Allow-Origin'));
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
     }
 
     /**
@@ -238,13 +237,13 @@ public function it_doesnt_add_a_vary_header_when_simple_origins()
     public function it_adds_a_vary_header_when_multiple_origins()
     {
         $app = $this->createStackedApp(array(
-           'allowedOrigins' => array('localhost', 'http://example.com')
+           'allowedOrigins' => array('http://localhost', 'http://example.com')
         ));
         $request  = $this->createValidActualRequest();
 
         $response = $app->handle($request);
 
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
         $this->assertTrue($response->headers->has('Vary'));
     }
 
@@ -278,12 +277,12 @@ public function it_returns_access_control_headers_on_cors_request()
     {
         $app      = $this->createStackedApp();
         $request  = new Request();
-        $request->headers->set('Origin', 'localhost');
+        $request->headers->set('Origin', 'http://localhost');
 
         $response = $app->handle($request);
 
         $this->assertTrue($response->headers->has('Access-Control-Allow-Origin'));
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
     }
 
     /**
@@ -300,7 +299,7 @@ public function it_returns_access_control_headers_on_cors_request_with_pattern_o
         $response = $app->handle($request);
 
         $this->assertTrue($response->headers->has('Access-Control-Allow-Origin'));
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
         $this->assertTrue($response->headers->has('Vary'));
         $this->assertEquals('Origin', $response->headers->get('Vary'));
     }
@@ -316,7 +315,7 @@ public function it_returns_access_control_headers_on_valid_preflight_request()
         $response = $app->handle($request);
 
         $this->assertTrue($response->headers->has('Access-Control-Allow-Origin'));
-        $this->assertEquals('localhost', $response->headers->get('Access-Control-Allow-Origin'));
+        $this->assertEquals('http://localhost', $response->headers->get('Access-Control-Allow-Origin'));
     }
 
     /**
@@ -325,7 +324,7 @@ public function it_returns_access_control_headers_on_valid_preflight_request()
     public function it_does_not_allow_request_with_origin_not_allowed()
     {
         $passedOptions = array(
-          'allowedOrigins' => array('notlocalhost'),
+          'allowedOrigins' => array('http://notlocalhost'),
         );
 
         $service  = new CorsService($passedOptions);
@@ -504,15 +503,15 @@ public function it_skips_empty_access_control_request_header()
     private function createValidActualRequest()
     {
         $request  = new Request();
-        $request->headers->set('Origin', 'localhost');
+        $request->headers->set('Origin', 'http://localhost');
 
         return $request;
     }
 
     private function createValidPreflightRequest()
     {
         $request  = new Request();
-        $request->headers->set('Origin', 'localhost');
+        $request->headers->set('Origin', 'http://localhost');
         $request->headers->set('Access-Control-Request-Method', 'get');
         $request->setMethod('OPTIONS');
 
@@ -524,7 +523,7 @@ private function createStackedApp(array $options = array(), array $responseHeade
         $passedOptions = array_merge(array(
                 'allowedHeaders'      => array('x-allowed-header', 'x-other-allowed-header'),
                 'allowedMethods'      => array('delete', 'get', 'post', 'put'),
-                'allowedOrigins'      => array('localhost'),
+                'allowedOrigins'      => array('http://localhost'),
                 'exposedHeaders'      => false,
                 'maxAge'              => false,
                 'supportsCredentials' => false,