Skip to content

Commit 8d8f88b

Browse files
authored
PHP 8 Support (#83)
* PHP 8 Support * Fix whitespace issue * Run builds on Pull Requests
1 parent 88aaf08 commit 8d8f88b

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.github/workflows/run-tests.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
on:
22
push:
3+
pull_request:
34
schedule:
45
- cron: '0 0 * * *'
56

@@ -9,7 +10,7 @@ jobs:
910

1011
strategy:
1112
matrix:
12-
php: [7.4, 7.3, 7.2, 7.1, 7.0]
13+
php: [8.0, 7.4, 7.3, 7.2, 7.1, 7.0]
1314
dependency-version: [prefer-lowest, prefer-stable]
1415
os: [ubuntu-latest]
1516

@@ -34,4 +35,4 @@ jobs:
3435

3536
- name: Check PSR-12 Codestyle
3637
run: vendor/bin/phpcs --standard=psr12 src/
37-
if: matrix.os == 'ubuntu-latest'
38+
if: matrix.os == 'ubuntu-latest'

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
}
1313
],
1414
"require": {
15-
"php": "^7.0",
15+
"php": "^7.0|^8.0",
1616
"symfony/http-foundation": "~2.7|~3.0|~4.0|~5.0",
1717
"symfony/http-kernel": "~2.7|~3.0|~4.0|~5.0"
1818
},

src/CorsService.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public function handlePreflightRequest(Request $request): Response
8484
public function addPreflightRequestHeaders(Response $response, Request $request): Response
8585
{
8686
$this->configureAllowedOrigin($response, $request);
87-
87+
8888
if ($response->headers->has('Access-Control-Allow-Origin')) {
8989
$this->configureAllowCredentials($response, $request);
9090

0 commit comments

Comments
 (0)