[FIX] Fixing key binding for Space Bar translation and localization

because of Issue in JS - Uncaught TypeError: A message must be provided as a String or AST.

Author: fschoelzel

Resources/Private/DevServer/app-config.js

@@ -82,7 +82,7 @@ var lang = {
       "error.mastodon.invalid_link": "Invalid Link URL.",
       "error.mastodon.enter_url": "Please enter a Mastodon instance URL.",
       "key.generic": "{key}",
-      "key. ": "Space Bar",
+      "key.Space": "Space Bar",
       "key.ArrowDown": "\u25bc",
       "key.ArrowLeft": "\u25c0",
       "key.ArrowRight": "\u25b6",

Resources/Private/JavaScript/SlubMediaPlayer/keybindings.test.js

@@ -16,6 +16,7 @@ describe('format translated key description', () => {
     locale: 'en_US',
     twoLetterIsoCode: 'en',
     phrases: {
+      'key.Space': 'Space Bar',
       'key.ArrowRight': "Arrow Right",
       'key.generic': "Key {key}",
       'key.generic.mod': "{key}",
@@ -26,6 +27,15 @@ describe('format translated key description', () => {
     },
   });
 
+  test('space bar translation', () => {
+    const kb = keybindings.find(kb =>
+      kb.action === 'playback.toggle' &&
+      kb.keys.includes(' ')
+    );
+    const text = getKeybindingText(env, /** @type {any} */(kb));
+    expect(text.innerHTML).toBe('<kbd>Space Bar</kbd>');
+  });
+
   test('key S for opening screenshot modal', () => {
     const kb = keybindings.find(kb => kb.action === 'modal.screenshot.open');
     const text = getKeybindingText(env, /** @type {any} */(kb));

Resources/Private/JavaScript/SlubMediaPlayer/lib/trans.js

@@ -12,6 +12,11 @@ import { Keybinding$splitKeyRanges } from 'lib/Keyboard';
  * @returns {string}
  */
 export function getKeyText(env, key, mod) {
+  // Space Bar is a special case
+  if (key === ' ') {
+    key = 'Space';
+  }
+
   const app = mod ? '.mod' : '';
   return env.t(`key.${key}${app}`, {},
     () => env.t(`key.${key}`, {},

Resources/Private/Language/de.locallang_media.xlf

@@ -321,9 +321,9 @@
 				<source><![CDATA[{key}]]></source>
 				<target><![CDATA[{key}]]></target>
 			</trans-unit>
-			<trans-unit id="key. " approved="yes">
+			<trans-unit id="key.Space" approved="yes">
 				<source><![CDATA[Space Bar]]></source>
-				<target><![CDATA[     ]]></target>
+				<target><![CDATA[Leertaste]]></target>
 			</trans-unit>
 			<trans-unit id="key.ArrowDown" approved="yes">
 				<source><![CDATA[▼]]></source>

Resources/Private/Language/locallang_media.xlf

@@ -242,7 +242,7 @@
 			<trans-unit id="key.generic">
 				<source><![CDATA[{key}]]></source>
 			</trans-unit>
-			<trans-unit id="key. ">
+			<trans-unit id="key.Space">
 				<source><![CDATA[Space Bar]]></source>
 			</trans-unit>
 			<trans-unit id="key.ArrowDown">