[MAINTENANCE] Maintenance in Indexer class (kitodo#1793)

Co-authored-by: Sebastian Meyer <sebastian.meyer@opencultureconsulting.com>

Author: beatrycze-volk

Classes/Common/Indexer.php

@@ -245,7 +245,7 @@ public static function delete(InputInterface $input, string $field, int $solrCor
     public static function getIndexFieldName(string $indexName, int $pid = 0): string
     {
         // Sanitize input.
-        $pid = max((int) $pid, 0);
+        $pid = max($pid, 0);
         if (!$pid) {
             Helper::error('Invalid PID ' . $pid . ' for metadata configuration');
             return '';
@@ -372,7 +372,7 @@ protected static function processLogical(Document $document, array $logicalUnit)
                 $solrDoc->setField('title', $metadata['title'][0]);
                 $solrDoc->setField('volume', $metadata['volume'][0] ?? '');
                 // verify date formatting
-                if(strtotime($metadata['date'][0])) {
+                if (strtotime($metadata['date'][0])) {
                     $solrDoc->setField('date', self::getFormattedDate($metadata['date'][0]));
                 }
                 $solrDoc->setField('record_id', $metadata['record_id'][0] ?? '');
@@ -530,7 +530,7 @@ private static function processMetadata(Document $document, array $metadata, Que
             // TODO: Include also subentries if available.
             if (
                 !empty($data)
-                && substr($indexName, -8) !== '_sorting'
+                && !str_ends_with($indexName, '_sorting')
             ) {
                 $solrDoc->setField(self::getIndexFieldName($indexName, $document->getPid()), $data);
                 if (in_array($indexName, self::$fields['sortables']) &&
@@ -575,7 +575,7 @@ private static function addFaceting($doc, QueryDocument &$solrDoc, array $physic
                     foreach ($doc->metadataArray[$logicalId] as $indexName => $data) {
                         if (
                             !empty($data)
-                            && substr($indexName, -8) !== '_sorting'
+                            && !str_ends_with($indexName, '_sorting')
                         ) {
                             if (in_array($indexName, self::$fields['facets'])) {
                                 // Remove appended "valueURI" from authors' names for indexing.
@@ -609,7 +609,7 @@ private static function addFaceting($doc, QueryDocument &$solrDoc, array $physic
             // Add sorting information to physical sub-elements if applicable.
             if (
                 !empty($data)
-                && substr($indexName, -8) == '_sorting'
+                && str_ends_with($indexName, '_sorting')
             ) {
                 $solrDoc->setField($indexName, $doc->metadataArray[$doc->getToplevelId()][$indexName]);
             }
@@ -689,16 +689,16 @@ private static function getSolrDocument(Query $updateQuery, Document $document,
     private static function getFormattedDate(string $date): string
     {
         if (
-            preg_match("/^[\d]{4}$/", $date)
-            || preg_match("/^[\d]{4}-[\d]{2}$/", $date)
-            || preg_match("/^[\d]{4}-[\d]{2}-[\d]{2}$/", $date)
+            preg_match("/^\d{4}$/", $date)
+            || preg_match("/^\d{4}-\d{2}$/", $date)
+            || preg_match("/^\d{4}-\d{2}-\d{2}$/", $date)
         ) {
             return $date;
-        // change date YYYYMMDD to YYYY-MM-DD
-        } elseif (preg_match("/^[\d]{8}$/", $date)) {
+        } elseif (preg_match("/^\d{8}$/", $date)) {
+            // change date YYYYMMDD to YYYY-MM-DD
             return date("Y-m-d", strtotime($date));
-        // convert any datetime to proper ISO extended datetime format and timezone for SOLR
         } elseif (preg_match("/^[0-9]{4}-[0-9]{2}-[0-9]{2}T.*$/", $date)) {
+            // convert any datetime to proper ISO extended datetime format and timezone for SOLR
             return date('Y-m-d\TH:i:s\Z', strtotime($date));
         }
         // date doesn't match any standard