[MAINTENANCE] Minor maintenance in IndexCommand (kitodo#1694)

Author: beatrycze-volk

Classes/Command/IndexCommand.php

@@ -96,7 +96,7 @@ public function configure(): void
      */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $dryRun = $input->getOption('dry-run') != false ? true : false;
+        $dryRun = $input->getOption('dry-run') != false;
 
         $io = new SymfonyStyle($input, $output);
         $io->title($this->getDescription());
@@ -121,13 +121,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 foreach ($allSolrCores as $indexName => $uid) {
                     $outputSolrCores[] = $uid . ' : ' . $indexName;
                 }
+
                 if (empty($outputSolrCores)) {
                     $io->error('ERROR: No valid Solr core ("' . $input->getOption('solr') . '") given. No valid cores found on PID ' . $this->storagePid . ".\n");
-                    return Command::FAILURE;
                 } else {
                     $io->error('ERROR: No valid Solr core ("' . $input->getOption('solr') . '") given. ' . "Valid cores are (<uid>:<index_name>):\n" . implode("\n", $outputSolrCores) . "\n");
-                    return Command::FAILURE;
                 }
+                return Command::FAILURE;
             }
         } else {
             $io->error('ERROR: Required parameter --solr|-s is missing or array.');