add Path and default traverse into VisitLetOrUse (#5158)

Author: vasily-kirichenko

src/fsharp/service/ServiceParseTreeWalk.fs

@@ -83,8 +83,8 @@ module public AstTraversal =
         abstract VisitComponentInfo : SynComponentInfo -> 'T option
         default this.VisitComponentInfo (_) = None
         /// VisitLetOrUse allows overriding behavior when visiting module or local let or use bindings
-        abstract VisitLetOrUse : SynBinding list * range -> 'T option
-        default this.VisitLetOrUse (_, _) = None
+        abstract VisitLetOrUse : TraversePath * (SynBinding -> 'T option) * SynBinding list * range -> 'T option
+        default this.VisitLetOrUse (_, _, _, _) = None
         /// VisitType allows overriding behavior when visiting simple pats
         abstract VisitSimplePats : SynSimplePat list -> 'T option
         default this.VisitSimplePats (_) = None
@@ -158,7 +158,7 @@ module public AstTraversal =
                 | SynModuleDecl.ModuleAbbrev(_ident, _longIdent, _range) -> None
                 | SynModuleDecl.NestedModule(_synComponentInfo, _isRec, synModuleDecls, _, _range) -> synModuleDecls |> List.map (fun x -> dive x x.Range (traverseSynModuleDecl path)) |> pick decl
                 | SynModuleDecl.Let(_, synBindingList, range) ->
-                    match visitor.VisitLetOrUse(synBindingList, range) with
+                    match visitor.VisitLetOrUse(path, traverseSynBinding path, synBindingList, range) with
                     | Some x -> Some x
                     | None -> synBindingList |> List.map (fun x -> dive x x.RangeOfBindingAndRhs (traverseSynBinding path)) |> pick decl
                 | SynModuleDecl.DoExpr(_sequencePointInfoForBinding, synExpr, _range) -> traverseSynExpr path synExpr  
@@ -364,7 +364,7 @@ module public AstTraversal =
                         |> pick expr
                 | SynExpr.TypeApp(synExpr, _, _synTypeList, _commas, _, _, _range) -> traverseSynExpr synExpr
                 | SynExpr.LetOrUse(_, _, synBindingList, synExpr, range) -> 
-                    match visitor.VisitLetOrUse(synBindingList, range) with
+                    match visitor.VisitLetOrUse(path, traverseSynBinding path, synBindingList, range) with
                     | Some x -> Some x
                     | None ->
                         [yield! synBindingList |> List.map (fun x -> dive x x.RangeOfBindingAndRhs (traverseSynBinding path))
@@ -586,7 +586,7 @@ module public AstTraversal =
                 ] |> pick m
             | SynMemberDefn.AutoProperty(_attribs, _isStatic, _id, _tyOpt, _propKind, _, _xmlDoc, _access, synExpr, _, _) -> traverseSynExpr path synExpr
             | SynMemberDefn.LetBindings(synBindingList, _, _, range) -> 
-                match visitor.VisitLetOrUse(synBindingList, range) with
+                match visitor.VisitLetOrUse(path, traverseSynBinding path, synBindingList, range) with
                 | Some x -> Some x
                 | None -> synBindingList |> List.map (fun x -> dive x x.RangeOfBindingAndRhs (traverseSynBinding path)) |> pick m
             | SynMemberDefn.AbstractSlot(_synValSig, _memberFlags, _range) -> None

src/fsharp/service/ServiceUntypedParse.fs

@@ -1289,7 +1289,7 @@ module UntypedParseImpl =
                         if rangeContainsPos range pos then Some CompletionContext.Invalid
                         else None
 
-                    member __.VisitLetOrUse(bindings, range) =
+                    member __.VisitLetOrUse(_, _, bindings, range) =
                         match bindings with
                         | [] when range.StartLine = pos.Line -> Some CompletionContext.Invalid
                         | _ -> None