Skip to content

Commit 82e1d2f

Browse files
authored
Merge pull request #3893 from Microsoft/merges/dev15.6-to-master-20171106-080116
Merge dev15.6 to master
2 parents 690fdc4 + 8a96a49 commit 82e1d2f

File tree

6 files changed

+43
-11
lines changed

6 files changed

+43
-11
lines changed

build.cmd

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@ rem Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt
44
setlocal enableDelayedExpansion
55

66
:ARGUMENTS_VALIDATION
7-
8-
if /I "%1" == "--help" (goto :USAGE)
7+
if /I "%1" == "--help" (goto :USAGE)
98
if /I "%1" == "/help" (goto :USAGE)
109
if /I "%1" == "/h" (goto :USAGE)
1110
if /I "%1" == "/?" (goto :USAGE)
1211
goto :ARGUMENTS_OK
1312

13+
1414
:USAGE
1515

1616
echo Build and run a subset of test suites
@@ -92,6 +92,10 @@ for %%i in (%BUILD_FSC_DEFAULT%) do ( call :PROCESS_ARG %%i )
9292

9393
REM apply defaults
9494

95+
if /i "%_buildexit%" == "1" (
96+
exit /B %_buildexitvalue%
97+
)
98+
9599
if /i "%_autoselect%" == "1" (
96100
set BUILD_NET40_FSHARP_CORE=1
97101
set BUILD_NET40=1
@@ -129,6 +133,12 @@ set ARG2=%~2
129133
if "%ARG%" == "1" if "%2" == "" (set ARG=default)
130134
if "%2" == "" if not "%ARG%" == "default" goto :EOF
131135

136+
rem Do no work
137+
if /i "%ARG%" == "none" (
138+
set _buildexit=1
139+
set _buildexitvalue=0
140+
)
141+
132142
if /i "%ARG%" == "net40-lib" (
133143
set _autoselect=0
134144
set BUILD_NET40_FSHARP_CORE=1

build.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,11 @@ do
138138
"nobuild")
139139
export BUILD_PHASE=0
140140
;;
141+
"none")
142+
_autoselect=0
143+
export _buildexit=1
144+
export _buildexitVALUE=0
145+
;;
141146
"all")
142147
_autoselect=0
143148
export BUILD_PROTO=1
@@ -320,6 +325,10 @@ do
320325
esac
321326
done
322327

328+
if [ $_buildexit -eq 1 ]; then
329+
exit $_buildexitvalue
330+
fi
331+
323332
# Apply defaults, if necessary.
324333
if [ $_autoselect -eq 1 ]; then
325334
export BUILD_NET40=1

netci.groovy

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ def static getBuildJobName(def configuration, def os) {
2121
// Linux
2222
configurations = ['Release', 'Release_fcs' ];
2323
}
24+
2425
configurations.each { configuration ->
2526

2627
def lowerConfiguration = configuration.toLowerCase()
@@ -68,7 +69,7 @@ def static getBuildJobName(def configuration, def os) {
6869
build_args = "net40"
6970
}
7071
else {
71-
build_args = "ci"
72+
build_args = "none"
7273
}
7374
}
7475

@@ -102,13 +103,14 @@ ${buildPath}build.cmd ${buildFlavor} ${build_args}""")
102103
Utilities.setMachineAffinity(newJob, os, affinity)
103104
Utilities.standardJobSetup(newJob, project, isPullRequest, "*/${branch}")
104105

105-
106-
Utilities.addArchival(newJob, "tests/TestResults/*.*", "", skipIfNoTestFiles, false)
107-
if (configuration == "Release_fcs") {
108-
Utilities.addArchival(newJob, "Release/**")
109-
}
110-
else {
111-
Utilities.addArchival(newJob, "${buildFlavor}/**")
106+
if (build_args != "none") {
107+
Utilities.addArchival(newJob, "tests/TestResults/*.*", "", skipIfNoTestFiles, false)
108+
if (configuration == "Release_fcs") {
109+
Utilities.addArchival(newJob, "Release/fcs/**")
110+
}
111+
else {
112+
Utilities.addArchival(newJob, "${buildFlavor}/**")
113+
}
112114
}
113115
if (isPullRequest) {
114116
Utilities.addGithubPRTriggerForBranch(newJob, branch, "${os} ${configuration} Build")

vsintegration/src/FSharp.LanguageService/FSharp.LanguageService.fsproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
<GeneratedModuleName>Microsoft.VisualStudio.FSharp.LanguageService.Strings</GeneratedModuleName>
6868
</EmbeddedResource>
6969
<Compile Include="AssemblyInfo.fs" />
70+
<Compile Include="LanguageServiceConstants.fs" />
7071
<Compile Include="Error.fs" />
7172
<Compile Include="Vs.fs" />
7273
<Compile Include="Colorize.fs" />
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.
2+
3+
namespace Microsoft.VisualStudio.FSharp.LanguageService
4+
5+
[<RequireQualifiedAccess>]
6+
module internal LanguageServiceConstants =
7+
8+
/// "F#"
9+
[<Literal>]
10+
let FSharpLanguageName = "F#"

vsintegration/src/FSharp.LanguageService/ProjectSitesAndFiles.fs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ type internal ProjectSitesAndFiles() =
274274
if not (isNull project) then
275275
for reference in project.ProjectReferences do
276276
let project = workspace.CurrentSolution.GetProject(reference.ProjectId)
277-
if not (isNull project) then
277+
if not (isNull project) && project.Language = LanguageServiceConstants.FSharpLanguageName then
278278
let siteProvider = provideProjectSiteProvider (workspace, project, serviceProvider, projectOptionsTable)
279279
let referenceProject = workspace.ProjectTracker.GetProject(reference.ProjectId)
280280
let outputPath = referenceProject.BinOutputPath

0 commit comments

Comments
 (0)