fix csharp tests

Author: dsyme

tests/service/CSharpProjectAnalysis.fs

@@ -22,31 +22,11 @@ open Microsoft.FSharp.Compiler.SourceCodeServices
 
 open FSharp.Compiler.Service.Tests.Common
 
-let internal getProjectReferences (content, dllFiles, libDirs, otherFlags) = 
-    let otherFlags = defaultArg otherFlags []
-    let libDirs = defaultArg libDirs []
-    let base1 = Path.GetTempFileName()
-    let dllName = Path.ChangeExtension(base1, ".dll")
-    let fileName1 = Path.ChangeExtension(base1, ".fs")
-    let projFileName = Path.ChangeExtension(base1, ".fsproj")
-    File.WriteAllText(fileName1, content)
-    let options =
-        checker.GetProjectOptionsFromCommandLineArgs(projFileName,
-            [| yield "--debug:full" 
-               yield "--define:DEBUG" 
-               yield "--optimize-" 
-               yield "--out:" + dllName
-               yield "--doc:test.xml" 
-               yield "--warn:3" 
-               yield "--fullpaths" 
-               yield "--flaterrors" 
-               yield "--target:library" 
-               for dllFile in dllFiles do
-                 yield "-r:"+dllFile
-               for libDir in libDirs do
-                 yield "-I:"+libDir
-               yield! otherFlags
-               yield fileName1 |])
+let internal getProjectReferences (content, dllFiles) = 
+    let fileName, options = 
+      mkTestFileAndOptions content 
+       [| for dllFile in dllFiles do
+            yield "-r:"+dllFile |]
     let results = checker.ParseAndCheckProject(options) |> Async.RunSynchronously
     if results.HasCriticalErrors then
         let builder = new System.Text.StringBuilder()
@@ -67,7 +47,7 @@ let internal getProjectReferences (content, dllFiles, libDirs, otherFlags) =
 #endif
 let ``Test that csharp references are recognized as such`` () = 
     let csharpAssembly = PathRelativeToTestAssembly "CSharp_Analysis.dll"
-    let _, table = getProjectReferences("""module M""", [csharpAssembly], None, None)
+    let _, table = getProjectReferences("""module M""", [csharpAssembly])
     let ass = table.["CSharp_Analysis"]
     let search = ass.Contents.Entities |> Seq.tryFind (fun e -> e.DisplayName = "CSharpClass") 
     Assert.True search.IsSome
@@ -113,7 +93,7 @@ let _ = CSharpOuterClass.InnerEnum.Case1
 let _ = CSharpOuterClass.InnerClass.StaticMember()
 """
 
-    let results, _ = getProjectReferences(content, [csharpAssembly], None, None)
+    let results, _ = getProjectReferences(content, [csharpAssembly])
     results.GetAllUsesOfAllSymbols()
     |> Async.RunSynchronously
     |> Array.map (fun su -> su.Symbol.ToString())
@@ -134,7 +114,7 @@ open FSharp.Compiler.Service.Tests
 
 let _ = CSharpClass(0)
 """
-    let results, _ = getProjectReferences(content, [csharpAssembly], None, None)
+    let results, _ = getProjectReferences(content, [csharpAssembly])
     let ctor =
             results.GetAllUsesOfAllSymbols()
             |> Async.RunSynchronously