draft (#1023)

* format

* snaps

* You've hit your limit · resets 11am (America/New_York)

Author: fshowalter

booklog/exports/reading_entries.py

@@ -9,7 +9,7 @@
 
 
 class JsonReadingEntry(TypedDict):
-    readingEntrySequence: int
+    readingEntrySequence: str
     slug: str
     edition: str
     readingEntryDate: datetime.date
@@ -37,11 +37,8 @@ def _build_json_reading_entry(
     work = reading.work(repository_data.works)
     reviewed = bool(work.review(repository_data.reviews))
 
-    # Create the key tuple for looking up the sequence number
-    entry_key = (str(reading_entry.date), str(reading.timeline[-1].date), str(reading.sequence))
-
     return JsonReadingEntry(
-        readingEntrySequence=repository_data.reading_entry_sequence_map.get(entry_key, 0),
+        readingEntrySequence=f"{reading_entry.date}-{reading.timeline[-1].date}-{reading.sequence:02d}",
         slug=work.slug,
         edition=reading.edition,
         kind=work.kind,

booklog/exports/repository_data.py

@@ -11,15 +11,11 @@ class RepositoryData:
     readings: list[repository_api.Reading]
     reviews: list[repository_api.Review]
     review_sequence_map: dict[str, str] = field(default_factory=dict, init=False)
-    reading_entry_sequence_map: dict[tuple[str, str, str], int] = field(
-        default_factory=dict, init=False
-    )
     reading_sequence_map: dict[tuple[str, int], int] = field(default_factory=dict, init=False)
 
     def __post_init__(self) -> None:
         """Calculate sequence maps after initialization."""
         self.review_sequence_map = self._build_review_sequence_map()
-        self.reading_entry_sequence_map = self._build_reading_entry_sequence_map()
         self.reading_sequence_map = self._build_reading_sequence_map()
 
     def _build_review_sequence_map(self) -> dict[str, str]:
@@ -41,31 +37,6 @@ def _build_review_sequence_map(self) -> dict[str, str]:
 
         return review_sequences
 
-    def _build_reading_entry_sequence_map(self) -> dict[tuple[str, str, str], int]:
-        """Build a mapping of timeline entries to their sequence number.
-
-        Returns a dictionary where keys are tuples of
-        (timeline_date, last_timeline_date, reading_sequence)
-        and values are their 1-based position in the sorted order.
-        """
-        timeline_entries: list[tuple[tuple[str, str, str], str]] = []
-
-        for reading in self.readings:
-            for timeline_entry in reading.timeline:
-                # Key is a tuple for unique identification
-                key = (
-                    str(timeline_entry.date),
-                    str(reading.timeline[-1].date),
-                    str(reading.sequence),
-                )
-                # Sort key matches the original string format for ordering
-                sort_key = f"{timeline_entry.date}-{reading.timeline[-1].date}-{reading.sequence}"
-                timeline_entries.append((key, sort_key))
-
-        # Sort by the sort_key in chronological order
-        sorted_entries = sorted(timeline_entries, key=lambda x: x[1])
-        return {key: idx + 1 for idx, (key, _) in enumerate(sorted_entries)}
-
     def _build_reading_sequence_map(self) -> dict[tuple[str, int], int]:
         """Build a mapping of reading (last_timeline_date, sequence) to their sort position.
 

tests/exports/__snapshots__/test_api/test_exports_reading_entries.json

@@ -12,7 +12,7 @@
     "kind": "Nonfiction",
     "progress": "Finished",
     "readingEntryDate": "2016-03-12",
-    "readingEntrySequence": 3,
+    "readingEntrySequence": "2016-03-12-2016-03-12-01",
     "reviewed": true,
     "slug": "on-writing-by-stephen-king",
     "title": "On Writing",
@@ -31,7 +31,7 @@
     "kind": "Nonfiction",
     "progress": "50%",
     "readingEntryDate": "2016-03-11",
-    "readingEntrySequence": 2,
+    "readingEntrySequence": "2016-03-11-2016-03-12-01",
     "reviewed": true,
     "slug": "on-writing-by-stephen-king",
     "title": "On Writing",
@@ -50,7 +50,7 @@
     "kind": "Nonfiction",
     "progress": "15%",
     "readingEntryDate": "2016-03-10",
-    "readingEntrySequence": 1,
+    "readingEntrySequence": "2016-03-10-2016-03-12-01",
     "reviewed": true,
     "slug": "on-writing-by-stephen-king",
     "title": "On Writing",