Merge pull request #346 from fslaborg/fix-#345-removeColAt

fix removeColAt indexing

Author: bvenn

src/FSharp.Stats/Matrix.fs

@@ -1493,7 +1493,7 @@ module Matrix =
                 else
                     loop (nColI) (colI-1)
 
-        loop (nRows-2) (nRows-1)
+        loop (nCols-2) (nCols-1)
 
     /// <summary>Splits a matrix along row direction according to given indices. Returns (matrix including rows according to indices, rest)</summary>
     /// <remarks></remarks>

tests/FSharp.Stats.Tests/FSharp.Stats.Tests.fsproj

@@ -74,7 +74,7 @@
   <ItemGroup>
     <PackageReference Include="altcover" Version="8.6.68" />
     <PackageReference Include="Expecto" Version="10.*" />
-    <PackageReference Include="YoloDev.Expecto.TestSdk" Version="0.*" />
+    <PackageReference Include="YoloDev.Expecto.TestSdk" Version="0.14.*" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="OptimizedPriorityQueue" Version="5.1.0" />
     <PackageReference Include="Deedle" Version="3.0.0" />

tests/FSharp.Stats.Tests/Matrix.fs

@@ -1183,6 +1183,37 @@ let floatImplementationDenseTests =
                 testCase "getRows" <| fun () ->
                     ()
             ]
+            testList "removeCols" [
+                testCase "removeColAt" <| fun () ->
+                    let m =
+                        [|
+                            [|0.;1.|]
+                            [|0.;3.|]
+                            [|0.;5.|]
+                        |] |> Matrix.ofJaggedArray
+                    let actual = Matrix.removeColAt 0 m
+                    let expected =
+                        [|
+                            [|1.|]
+                            [|3.|]
+                            [|5.|]
+                        |] |> Matrix.ofJaggedArray
+                    Expect.equal actual expected "Matrix.removeColAt did not return the correct matrix"
+            ]
+            testList "removeRows" [
+                testCase "removeRowAt" <| fun () ->
+                    let m =
+                        [|
+                            [|0.;0.;0.;|]
+                            [|1.;3.;5.;|]
+                        |] |> Matrix.ofJaggedArray
+                    let actual = Matrix.removeRowAt 1 m
+                    let expected =
+                        [|
+                            [|0.;0.;0.|]
+                        |] |> Matrix.ofJaggedArray
+                    Expect.equal actual expected "Matrix.removeRowAt did not return the correct matrix"
+            ]
             testList "getRegion" [
 
                 testCase "get Region" <| fun () ->