Fix go vet errors and add go vet checks to the github actions

Author: fsmv

.github/workflows/tests.yml

@@ -28,6 +28,9 @@ jobs:
         GOTOOLCHAIN=local go version
         GOTOOLCHAIN=local go build -v ./...
 
+    - name: Vet daemon
+      run: go vet ./...
+
     - name: Run daemon unit tests
       run: go test -race -v ./...
 

portal/integration_test.go

@@ -409,6 +409,7 @@ func equalCerts(lhs, rhs [][]byte) bool {
 func (*PortalTest) AutoRegister_ClientCert(t *testing.T) {
 	t.Parallel()
 	ctx, done := context.WithDeadline(t.Context(), time.Now().Add(15*time.Second))
+	defer done()
 	ret, wait, err := gate.AutoRegister(ctx, &gate.RegisterRequest{
 		Pattern: fmt.Sprintf("/%v/", t.Name()),
 	})
@@ -459,7 +460,8 @@ func (*PortalTest) AutoRegister_Wait(t *testing.T) {
 	t.Parallel()
 	const testTime = time.Second
 	start := time.Now()
-	ctx, _ := context.WithTimeout(t.Context(), testTime)
+	ctx, done := context.WithTimeout(t.Context(), testTime)
+	defer done()
 	_, wait, err := gate.AutoRegister(ctx, &gate.RegisterRequest{
 		Pattern: fmt.Sprintf("/%v/", t.Name()),
 	})

spawn/embedspawn/dashboard.go

@@ -144,6 +144,7 @@ func startDashboard(ctx context.Context, children *children, adminAuth *tools.Ba
 	})
 	if err != nil {
 		close(dashboardQuit)
+		stopDashboard()
 		return dashboardQuit, err
 	}
 	wg.Add(1)
@@ -159,6 +160,7 @@ func startDashboard(ctx context.Context, children *children, adminAuth *tools.Ba
 	templates, err = templates.ParseFS(templatesFS, "*.tmpl.html")
 	if err != nil {
 		close(dashboardQuit)
+		stopDashboard()
 		return dashboardQuit, err
 	}
 	http.Handle(dashboardUrl, &dashboard{children, templates, adminAuth})