wip: fix some incompatibilities

Author: bartelink

src/FSharp.AWS.DynamoDB/Expression/ExprCommon.fs

@@ -249,10 +249,12 @@ type QuotedAttribute =
 
 /// Wrapper API for writing attribute names and values for Dynamo query expressions
 type AttributeWriter(names: Dictionary<string, string>, values: Dictionary<string, AttributeValue>) =
+    let names = if names = null then Dictionary() else names
+    let values = if values = null then Dictionary() else values
     static let cmp = new AttributeValueComparer()
     let vcontents = new Dictionary<AttributeValue, string>(cmp)
 
-    new() = new AttributeWriter(new Dictionary<_, _>(), new Dictionary<_, _>())
+    new() = AttributeWriter(Dictionary(), Dictionary())
 
     member __.Names = names
     member __.Values = values

src/FSharp.AWS.DynamoDB/RecordKeySchema.fs

@@ -391,7 +391,7 @@ type TableKeySchemata with
     member schema.ApplyToCreateTableRequest(ctr: CreateTableRequest) =
         let inline mkKSE n t = KeySchemaElement(n, t)
 
-        let keyAttrs = new Dictionary<string, KeyAttributeSchema>()
+        let keyAttrs = Dictionary<string, KeyAttributeSchema>()
         for tks in schema.Schemata do
             keyAttrs.[tks.HashKey.AttributeName] <- tks.HashKey
             tks.RangeKey |> Option.iter (fun rk -> keyAttrs.[rk.AttributeName] <- rk)
@@ -402,16 +402,14 @@ type TableKeySchemata with
                 tks.RangeKey |> Option.iter (fun rk -> ctr.KeySchema.Add <| mkKSE rk.AttributeName KeyType.RANGE)
 
             | GlobalSecondaryIndex name ->
-                let gsi = new GlobalSecondaryIndex()
-                gsi.IndexName <- name
+                let gsi = new GlobalSecondaryIndex(IndexName = name, KeySchema = ResizeArray())
                 gsi.KeySchema.Add <| mkKSE tks.HashKey.AttributeName KeyType.HASH
                 tks.RangeKey |> Option.iter (fun rk -> gsi.KeySchema.Add <| mkKSE rk.AttributeName KeyType.RANGE)
                 gsi.Projection <- Projection(ProjectionType = ProjectionType.ALL)
                 ctr.GlobalSecondaryIndexes.Add gsi
 
             | LocalSecondaryIndex name ->
-                let lsi = new LocalSecondaryIndex()
-                lsi.IndexName <- name
+                let lsi = new LocalSecondaryIndex(IndexName = name, KeySchema = ResizeArray())
                 lsi.KeySchema.Add <| mkKSE tks.HashKey.AttributeName KeyType.HASH
                 tks.RangeKey |> Option.iter (fun rk -> lsi.KeySchema.Add <| mkKSE rk.AttributeName KeyType.RANGE)
                 lsi.Projection <- Projection(ProjectionType = ProjectionType.ALL)

src/FSharp.AWS.DynamoDB/TableContext.fs

@@ -79,7 +79,7 @@ module internal Streaming =
 module internal CreateTableRequest =
 
     let create (tableName, template: RecordTemplate<'TRecord>) throughput streaming customize =
-        let req = CreateTableRequest(TableName = tableName)
+        let req = CreateTableRequest(tableName, ResizeArray(), GlobalSecondaryIndexes = ResizeArray(), LocalSecondaryIndexes = ResizeArray(), AttributeDefinitions = ResizeArray()) // init KeySchema to work with efault SDK v4 options
         template.Info.Schemata.ApplyToCreateTableRequest req // NOTE needs to precede the throughput application as that walks the GSIs list
         throughput |> Option.iter (Throughput.applyToCreateRequest req) // NOTE needs to succeed Schemata.ApplyToCreateTableRequest
         streaming |> Option.iter (Streaming.applyToCreateRequest req)
@@ -563,7 +563,7 @@ type TableContext<'TRecord>
         if items.Length > 25 then
             invalidArg "items" "item length must be less than or equal to 25."
         let writeRequests = items |> Seq.map mkWriteRequest |> rlist
-        let pbr = BatchWriteItemRequest(ReturnConsumedCapacity = returnConsumedCapacity)
+        let pbr = BatchWriteItemRequest(ReturnConsumedCapacity = returnConsumedCapacity, RequestItems = Dictionary())
         pbr.RequestItems[tableName] <- writeRequests
         let! ct = Async.CancellationToken
         let! response = client.BatchWriteItemAsync(pbr, ct) |> Async.AwaitTaskCorrect

src/FSharp.AWS.DynamoDB/Utils/DynamoUtils.fs

@@ -30,7 +30,7 @@ type AttributeValueComparer() =
         if av.NULL.HasValue then
             av'.NULL = av.NULL
         elif av.BOOL.HasValue then
-            av.BOOL = av'.BOOL
+            av'.BOOL = av.BOOL
         elif notNull av.S then
             notNull av'.S && av.S = av'.S
         elif notNull av.N then