Skip to content

Commit 181e840

Browse files
committed
IndexerAccesorStyleConsistency: clearer violation text
1 parent 1ffdef2 commit 181e840

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

src/FSharpLint.Core/Rules/Conventions/IndexerAccessorStyleConsistency.fs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ type Config = {
1313
Style: string
1414
}
1515

16-
let generateOutput (range: FSharp.Compiler.Text.Range) =
16+
let generateOutput (range: FSharp.Compiler.Text.Range) msg =
1717
Array.singleton
1818
{
1919
Range = range
20-
Message = Resources.GetString "RulesIndexerAccessorStyleConsistency"
20+
Message = Resources.GetString msg
2121
SuggestedFix = None
2222
TypeChecks = List.Empty
2323
}
@@ -32,7 +32,7 @@ let runner (config: Config) (args: AstNodeRuleParams) =
3232
SynExpr.App (ExprAtomicFlag.Atomic, _, SynExpr.Ident _, SynExpr.ArrayOrListComputed (_, expr, range), _),
3333
_, _, _)
3434
->
35-
generateOutput range
35+
generateOutput range "RulesIndexerAccessorStyleConsistencyToOCaml"
3636
| _ ->
3737
Array.empty
3838
| _ ->
@@ -43,7 +43,7 @@ let runner (config: Config) (args: AstNodeRuleParams) =
4343
match binding with
4444
| SynBinding (_, _, _, _, _, _, _, SynPat.Named _, _
4545
, SynExpr.DotIndexedGet (_, _, _, range), _, _, _) ->
46-
generateOutput range
46+
generateOutput range "RulesIndexerAccessorStyleConsistencyToCSharp"
4747
| _ ->
4848
Array.empty
4949
| _ ->

src/FSharpLint.Core/Text.resx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,6 @@
186186
<data name="RulesAvoidTooShortNamesError" xml:space="preserve">
187187
<value>Consider using a longer name, as it is currently too short.</value>
188188
</data>
189-
<data name="RulesIndexerAccessorStyleConsistency" xml:space="preserve">
190-
<value>Consider switching the indexer accessor from OCaml style to CSharp style or viceversa.</value>
191-
</data>
192189
<data name="RulesNamingConventionsPrefixError" xml:space="preserve">
193190
<value>Consider changing `{0}` to be prefixed with `{1}`.</value>
194191
</data>
@@ -387,4 +384,10 @@
387384
<data name="InterpolatedStringWithNoSubstitution" xml:space="preserve">
388385
<value>Do not use interpolated string syntax (with $ prefix) or formatting functions (sprintf, failwithf) when not really performing any interpolation.</value>
389386
</data>
387+
<data name="RulesIndexerAccessorStyleConsistencyToCSharp" xml:space="preserve">
388+
<value>Consider switching the indexer accessor to CSharp style.</value>
389+
</data>
390+
<data name="RulesIndexerAccessorStyleConsistencyToOCaml" xml:space="preserve">
391+
<value>Consider switching the indexer accessor to OCaml style.</value>
392+
</data>
390393
</root>

0 commit comments

Comments
 (0)