Core: fix remaining SelfCheck violations

Author: webwarrior-ws

src/FSharpLint.Core/Rules/Conventions/SourceLength/MaxLinesInFile.fs

@@ -15,7 +15,7 @@ let private checkNumberOfLinesInFile numberOfLines line maxLines =
         Array.singleton
             {
                 Range =
-                    Range.mkRange "" (Position.mkPos (maxLines + 1) 0) (Position.mkPos numberOfLines (String.length line))
+                    Range.mkRange String.Empty (Position.mkPos (maxLines + 1) 0) (Position.mkPos numberOfLines (String.length line))
                 Message = String.Format(errorFormatString, (maxLines + 1))
                 SuggestedFix = None
                 TypeChecks = List.Empty

src/FSharpLint.Core/Rules/Formatting/TupleFormatting/TupleIndentation.fs

@@ -16,7 +16,7 @@ let checkTupleIndentation _ (tupleExprs:SynExpr list) _ _ =
         if expr.Range.StartColumn <> nextExpr.Range.StartColumn then
             Some
                 {
-                    Range = Range.mkRange "" expr.Range.Start nextExpr.Range.End
+                    Range = Range.mkRange String.Empty expr.Range.Start nextExpr.Range.End
                     Message = Resources.GetString("RulesFormattingTupleIndentationError")
                     SuggestedFix = None
                     TypeChecks = List.Empty

src/FSharpLint.Core/Rules/Formatting/Typography/TrailingNewLineInFile.fs

@@ -11,7 +11,7 @@ let checkTrailingNewLineInFile (args:LineRuleParams) =
         let pos = Position.mkPos args.LineNumber 0
         Array.singleton
             {
-                Range = Range.mkRange "" pos pos
+                Range = Range.mkRange String.Empty pos pos
                 Message = Resources.GetString("RulesTypographyTrailingLineError")
                 SuggestedFix = None
                 TypeChecks = List.Empty

src/FSharpLint.Core/Rules/Hints/HintMatcher.fs

@@ -770,7 +770,7 @@ let private confirmFuzzyMatch (args:AstNodeRuleParams) (hint:HintParserTypes.Hin
         |> suggestions.Add
     | AstNode.Expression(expr), HintExpr(hintExpr) ->
         let arguments =
-            { MatchExpression.LambdaArguments = Map.ofList []
+            { MatchExpression.LambdaArguments = Map.empty
               MatchExpression.MatchedVariables = Dictionary<_, _>()
               MatchExpression.Expression = args.AstNode
               MatchExpression.Hint = hintExpr