Skip to content

Commit d0977e9

Browse files
authored
Merge PR #806 from webwarrior-ws/redundant-new-upcast
Add new tests for RedundantNewKeyword rule.
2 parents e8b63ae + c06be89 commit d0977e9

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed

tests/FSharpLint.Core.Tests/Rules/Conventions/RedundantNewKeyword.fs

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,3 +97,31 @@ module Program
9797

9898
Assert.IsTrue this.ErrorsExist
9999

100+
[<Test>]
101+
member this.``new keyword is required.``() =
102+
this.Parse
103+
"""
104+
open System
105+
106+
type ISomeInterfaceWithDisposable =
107+
interface
108+
inherit IDisposable
109+
end
110+
111+
type SomeDisposableType() =
112+
interface ISomeInterfaceWithDisposable with
113+
member _.Dispose() = ()
114+
115+
module Program =
116+
let foo = new SomeDisposableType() :> ISomeInterfaceWithDisposable"""
117+
118+
this.AssertNoWarnings()
119+
120+
[<Test>]
121+
member this.``New keyword is required for known type that implements IDisposable``() =
122+
this.Parse
123+
"""module Program
124+
125+
let foo = new System.Net.Http.HttpClient()"""
126+
127+
this.AssertNoWarnings()

0 commit comments

Comments
 (0)