FavourStaticEmptyFields: simplified expression processing

To not have duplicate code.

Author: webwarrior-ws

src/FSharpLint.Core/Rules/Conventions/FavourStaticEmptyFields.fs

@@ -38,32 +38,35 @@ let private generateError (fileContents: string) (range:FSharp.Compiler.Text.Ran
           SuggestedFix = Some suggestedFix
           TypeChecks = List.Empty }
 
-let private runner (args: AstNodeRuleParams) =
-    match args.AstNode with
-    | AstNode.Expression(SynExpr.Const (SynConst.String ("", _, range), _)) -> 
+let rec private processExpression (args: AstNodeRuleParams) (expression: SynExpr) =
+    match expression with
+    | SynExpr.Const(SynConst.String ("", _, range), _) -> 
         generateError args.FileContent range EmptyStringLiteral
-    | AstNode.Expression(SynExpr.ArrayOrList (isArray, [], range)) ->
+    | SynExpr.ArrayOrList (isArray, [], range) ->
         let emptyLiteralType =
             if isArray then EmptyArrayLiteral else EmptyListLiteral
         generateError args.FileContent range emptyLiteralType
-    | AstNode.Expression(SynExpr.Record(_, _, synExprRecordField, _)) ->
+    | SynExpr.App(_, _, _, argExpr, _) ->
+        processExpression args argExpr
+    | SynExpr.Record(_, _, synExprRecordFields, _) ->
         let mapping =
             function
             | SynExprRecordField(_, _, expr, _) ->
                 match expr with
-                | Some(SynExpr.ArrayOrList(isArray, [], range)) ->
-                    let emptyLiteralType = if isArray then EmptyArrayLiteral else EmptyListLiteral
-                    generateError args.FileContent range emptyLiteralType
-                | Some(SynExpr.Const (SynConst.String ("", _, range), _)) ->
-                    generateError args.FileContent range EmptyStringLiteral
-                | Some(SynExpr.App(_, _, _, SynExpr.Const (SynConst.String ("", _, range), _), _)) ->
-                    generateError args.FileContent range EmptyStringLiteral
+                | Some innerExpression ->
+                    processExpression args innerExpression
                 | _ -> Array.empty
-        synExprRecordField
+        synExprRecordFields
         |> List.map mapping
         |> Array.concat
     | _ -> Array.empty
 
+let private runner (args: AstNodeRuleParams) =
+    match args.AstNode with
+    | AstNode.Expression(expr) -> 
+        processExpression args expr
+    | _ -> Array.empty
+
 
 let rule =
     AstNodeRule