I0219 - verify test generated client method contains typed response#225
Closed
jkone27 wants to merge 3 commits intofsprojects:masterfrom
Closed
I0219 - verify test generated client method contains typed response#225jkone27 wants to merge 3 commits intofsprojects:masterfrom
jkone27 wants to merge 3 commits intofsprojects:masterfrom
Conversation
|
|
||
| let typedTask = inst.AskDetail(askDetailRequest: AcmeApi.AskDetailRequest) | ||
|
|
||
| typedTask.GetType().FullName.Contains("AskDetailResponse") |
Member
There was a problem hiding this comment.
It should be proper xUnit test -
I assume it fails now, right?
17 tasks
Member
|
@jkone27 do we still miss something or this pr is outdated? |
Contributor
Author
|
I think we can close/ignore this one yes. I forgot the context atm |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a check of the task type