Conversation
Verifies that formatting a match expression with a long anonymous record type in the discriminant no longer causes indentation warnings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
/repo-assist add changelog entry |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Commit pushed:
|
Contributor
|
/repo-assist always add your item last in the section, so weird that you shoved this in mid section |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Commit pushed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant.
Closes #1903
Summary
Issue #1903 reported that formatting a
matchexpression with a long anonymous record type in the discriminant (usingunbox<{| ... |}>) caused an indentation warning on the line inside the parentheses. This was filed against Fantomas 4.6 withMaxLineLength = 60.nojaf confirmed on 2026-02-24 that this is no longer a problem in the current version, and requested a regression test so the issue can be closed.
What This PR Does
Adds a regression test to
PatternMatchingTests.fsthat:matchexpression with a long nested anonymous record type as the discriminant (usingunbox) withMaxLineLength = 60source')Test Status
dotnet fantomas