Start enforcing bugbear rules (B) (#1602)

Author: DimitriPapadopoulos

fsspec/caching.py

@@ -15,6 +15,7 @@
     ClassVar,
     Generic,
     NamedTuple,
+    Optional,
     OrderedDict,
     TypeVar,
 )
@@ -574,7 +575,7 @@ def __init__(
         blocksize: int,
         fetcher: Fetcher,
         size: int,
-        data: dict[tuple[int, int], bytes] = {},
+        data: Optional[dict[tuple[int, int], bytes]] = None,
         strict: bool = True,
         **_: Any,
     ):
@@ -597,7 +598,7 @@ def __init__(
 
             self.data = dict(zip(offsets, blocks))
         else:
-            self.data = data
+            self.data = {}
 
     def _fetch(self, start: int | None, stop: int | None) -> bytes:
         if start is None:

fsspec/compression.py

@@ -139,7 +139,7 @@ def _fetch_range(self, start, end):
 try:
     import snappy
 
-    snappy.compress
+    snappy.compress(b"")
     # Snappy may use the .sz file extension, but this is not part of the
     # standard implementation.
     register_compression("snappy", SnappyFile, [])

fsspec/implementations/cached.py

@@ -425,7 +425,6 @@ def __getattribute__(self, item):
             "clear_cache",
             "clear_expired_cache",
             "pop_from_cache",
-            "_mkcache",
             "local_file",
             "_paths_from_path",
             "get_mapper",
@@ -438,9 +437,6 @@ def __getattribute__(self, item):
             "cache_size",
             "pipe_file",
             "pipe",
-            "isdir",
-            "isfile",
-            "exists",
             "start_transaction",
             "end_transaction",
         }:

fsspec/implementations/tests/test_archive.py

@@ -65,7 +65,7 @@ def temptar(data=None, mode="w", suffix=".tar"):
     fn = tempfile.mkstemp(suffix=suffix)[1]
     with tarfile.TarFile.open(fn, mode=mode) as t:
         touched = {}
-        for name, data in data.items():
+        for name, value in data.items():
             # Create directory hierarchy.
             # https://bugs.python.org/issue22208#msg225558
             if "/" in name and name not in touched:
@@ -78,8 +78,8 @@ def temptar(data=None, mode="w", suffix=".tar"):
 
             # Add file content.
             info = tarfile.TarInfo(name=name)
-            info.size = len(data)
-            t.addfile(info, BytesIO(data))
+            info.size = len(value)
+            t.addfile(info, BytesIO(value))
 
     try:
         yield fn

fsspec/implementations/tests/test_cached.py

@@ -1244,7 +1244,7 @@ def test_cache_size(tmpdir, protocol):
     # Remove cached file but leave cache metadata file
     fs.pop_from_cache(afile)
     if win and protocol == "filecache":
-        empty_cache_size < fs.cache_size()
+        assert empty_cache_size < fs.cache_size()
     elif protocol != "simplecache":
         assert empty_cache_size < fs.cache_size() < single_file_cache_size
     else:

fsspec/tests/test_api.py

@@ -168,14 +168,14 @@ def test_recursive_get_put(tmpdir, m):
     fs.get("test/", d, recursive=True)
     for file in ["one", "two", "nest/other"]:
         with open(f"{d}/{file}", "rb") as f:
-            f.read() == b"data"
+            assert f.read() == b"data"
 
     # get to directory without slash
     d = tempfile.mkdtemp()
     fs.get("test", d, recursive=True)
     for file in ["test/one", "test/two", "test/nest/other"]:
         with open(f"{d}/{file}", "rb") as f:
-            f.read() == b"data"
+            assert f.read() == b"data"
 
 
 def test_pipe_cat(m):

fsspec/tests/test_core.py

@@ -21,7 +21,8 @@
 
 
 @contextmanager
-def tempzip(data={}):
+def tempzip(data=None):
+    data = data or {}
     f = tempfile.mkstemp(suffix="zip")[1]
     with zipfile.ZipFile(f, mode="w") as z:
         for k, v in data.items():
@@ -311,7 +312,7 @@ def test_open_file_write_with_special_characters(tmp_path, char, monkeypatch):
         f.write(expected_content * 2)
 
     with open(file_path, "r") as f:
-        f.read() == actual_content * 2
+        assert f.read() == actual_content * 2
 
     assert actual_content == expected_content
 

fsspec/tests/test_utils.py

@@ -381,7 +381,7 @@ def client(self):
             return mock
 
         def func_2(self):
-            assert False, "have to overwrite this"
+            raise AssertionError("have to overwrite this")
 
         def func_3(self):
             return "should succeed"

fsspec/utils.py

@@ -435,7 +435,7 @@ def isfilelike(f: Any) -> TypeGuard[IO[bytes]]:
 
 def get_protocol(url: str) -> str:
     url = stringify_path(url)
-    parts = re.split(r"(\:\:|\://)", url, 1)
+    parts = re.split(r"(\:\:|\://)", url, maxsplit=1)
     if len(parts) > 1:
         return parts[0]
     return "file"

pyproject.toml

@@ -152,7 +152,7 @@ line-length = 88
 select = [
     # fix noqas in fsspec/implementations/http.py
     "ASYNC",
-    # "B", enable in later PR
+    "B",
     "I",    # isort
     "C4",
     "G",
@@ -178,6 +178,17 @@ select = [
     "SIM101",
 ]
 ignore = [
+	# Loop control variable `loop` not used within loop body
+	"B007",
+	# Use of `functools.lru_cache` or `functools.cache` on methods can lead to memory leaks
+	"B019",
+	# Star-arg unpacking after a keyword argument is strongly discouraged
+	"B026",
+	# No explicit `stacklevel` keyword argument found
+	"B028",
+	# Within an `except` clause, raise exceptions with `raise ... from err` or
+	# `raise ... from None` to distinguish them from errors in exception handling
+	"B904",
     # Assigning lambda expression
     "E731",
     # Ambiguous variable names