added type guards for MemoryFileSystem and name property to MemoryFile class (#1574)

* fix: _strip_protocol to stringify path

* Use rsplit instead of split for name in MemoryFile

* Added test, altered _strip_protocol to correct windows paths

* Removed redundant check from prior commit

* fix liint issues

* Update fsspec/implementations/tests/test_memory.py

Co-authored-by: Martin Durant <[email protected]>

* Rolled back name property in MemoryFileSystem

* Update fsspec/implementations/memory.py

Co-authored-by: Martin Durant <[email protected]>

* Changed memory file system to only accept PurePosixPath

* Handle PureWindowsPath in memfs

* Separated path tests to be platform specific, allowed for c:/ to show in memoryfs paths

* formatted code using black

* Moved imports in test_memory to fix lint issues

* Fixed import order in memory.py

---------

Co-authored-by: Martin Durant <[email protected]>

Author: austinsimpsond41

fsspec/implementations/memory.py

@@ -4,9 +4,12 @@
 from datetime import datetime, timezone
 from errno import ENOTEMPTY
 from io import BytesIO
+from pathlib import PurePath, PureWindowsPath
 from typing import Any, ClassVar
 
 from fsspec import AbstractFileSystem
+from fsspec.implementations.local import LocalFileSystem
+from fsspec.utils import stringify_path
 
 logger = logging.getLogger("fsspec.memoryfs")
 
@@ -25,6 +28,12 @@ class MemoryFileSystem(AbstractFileSystem):
 
     @classmethod
     def _strip_protocol(cls, path):
+        if isinstance(path, PurePath):
+            if isinstance(path, PureWindowsPath):
+                return LocalFileSystem._strip_protocol(path)
+            else:
+                path = stringify_path(path)
+
         if path.startswith("memory://"):
             path = path[len("memory://") :]
         if "::" in path or "://" in path:

fsspec/implementations/tests/test_memory.py

@@ -1,4 +1,5 @@
 import os
+from pathlib import PurePosixPath, PureWindowsPath
 
 import pytest
 
@@ -363,3 +364,19 @@ def test_cp_two_files(m):
         "/target/file0",
         "/target/file1",
     ]
+
+
+def test_open_path_posix(m):
+    path = PurePosixPath("/myfile/foo/bar")
+    with m.open(path, "wb") as f:
+        f.write(b"some\nlines\nof\ntext")
+
+    assert m.read_text(path) == "some\nlines\nof\ntext"
+
+
+def test_open_path_windows(m):
+    path = PureWindowsPath("C:\\myfile\\foo\\bar")
+    with m.open(path, "wb") as f:
+        f.write(b"some\nlines\nof\ntext")
+
+    assert m.read_text(path) == "some\nlines\nof\ntext"