Allow kwargs passed to open() with overrides (#1551)

Author: martindurant

fsspec/core.py

@@ -456,6 +456,8 @@ def open(
     - For implementations in separate packages see
       https://filesystem-spec.readthedocs.io/en/latest/api.html#other-known-implementations
     """
+    kw = {"expand": False}
+    kw.update(kwargs)
     out = open_files(
         urlpath=[urlpath],
         mode=mode,
@@ -464,8 +466,7 @@ def open(
         errors=errors,
         protocol=protocol,
         newline=newline,
-        expand=False,
-        **kwargs,
+        **kw,
     )
     if not out:
         raise FileNotFoundError(urlpath)

fsspec/implementations/local.py

@@ -132,6 +132,14 @@ def cp_file(self, path1, path2, **kwargs):
         else:
             raise FileNotFoundError(path1)
 
+    def isfile(self, path):
+        path = self._strip_protocol(path)
+        return os.path.isfile(path)
+
+    def isdir(self, path):
+        path = self._strip_protocol(path)
+        return os.path.isdir(path)
+
     def get_file(self, path1, path2, callback=None, **kwargs):
         if isfilelike(path2):
             with open(path1, "rb") as f: