Skip to content

Mismatch in glob API / Behavior between Async and Abstract Filesystems #1993

@marcm-ml

Description

@marcm-ml

Hello, there is a mismatch of the glob behavior between async and abstract filesystems.

In Async filesystems, the withdirs parameters is properly respected in **kwargs dict.
In Abstract filesystems this is not he case and withdirs hardcoded in self.find(..., withdirs=True, ..., **kwargs) which leads to duplicated keyword arguments if withdirs is provided in glob call.

It would be nice, if abstract followes the same behavior as async.

fs = filesystem("local")
fs.glob("mydir/*", withdirs=False) # error

fs = filesystem("s3fs")
fs.glob("s3://my-bucket/mydir/*", withdirs=False) # fine

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions