Merge pull request #13 from fsspec/FileNotFound

don't retry if object is known to be missing

Author: d70-t

ipfsspec/async_ipfs.py

@@ -202,6 +202,8 @@ async def _gw_op(self, op):
                     if state.speedup(time.monotonic() - now):
                         logger.debug("%s speedup", gw)
                     return res
+                except FileNotFoundError:  # early exit if object doesn't exist
+                    raise
                 except (RequestsTooQuick, aiohttp.ClientResponseError, asyncio.TimeoutError) as e:
                     state.backoff()
                     logger.debug("%s backoff %s", gw, e)

test/test_async_fallback.py

@@ -7,8 +7,10 @@
 class MockGateway(AsyncIPFSGatewayBase):
     def __init__(self, objects):
         self.objects = objects
+        self.request_count = 0
 
     async def cid_get(self, path, session, headers=None, **kwargs):
+        self.request_count += 1
         try:
             return self.objects[path]
         except KeyError:
@@ -71,3 +73,19 @@ async def test_backoff_use_faster_server(session):
         obj = await gw.cid_get("QmTz3oc4gdpRMKP2sdGUPZTAGRngqjsi99BPoztyP53JMM", session)
         assert obj == "zapp"
     assert gws[0].request_count < gws[1].request_count
+
+
+@pytest.mark.asyncio
+async def test_stop_on_not_found(session):
+    objects = {
+        "QmTz3oc4gdpRMKP2sdGUPZTAGRngqjsi99BPoztyP53JMM": "zapp",
+    }
+    gws = [
+        MockGateway(objects),
+        MockGateway(objects)
+    ]
+    gw = MultiGateway(gws)
+
+    with pytest.raises(FileNotFoundError):
+        await gw.cid_get("QmTz3oc4gdpRMKP2sdGUPZTAGRngqjsi99BPoztyP53JMM/not_there", session)
+    assert gws[1].request_count == 0