upath: fixes for extensions, StatResultType

Author: ap--

upath/extensions.py

@@ -284,7 +284,9 @@ def is_absolute(self) -> bool:
         return self.__wrapped__.is_absolute()
 
     def __eq__(self, other: object) -> bool:
-        return self.__wrapped__.__eq__(other)
+        if not isinstance(other, type(self)):
+            return NotImplemented
+        return self.__wrapped__.__eq__(other.__wrapped__)
 
     def __hash__(self) -> int:
         return self.__wrapped__.__hash__()
@@ -313,8 +315,11 @@ def lchmod(self, mode: int) -> None:
     def unlink(self, missing_ok: bool = False) -> None:
         self.__wrapped__.unlink(missing_ok=missing_ok)
 
-    def rmdir(self, recursive: bool = True) -> None:  # fixme: non-standard
-        self.__wrapped__.rmdir(recursive=recursive)
+    def rmdir(self, recursive: bool = UNSET_DEFAULT) -> None:  # fixme: non-standard
+        kwargs: dict[str, Any] = {}
+        if recursive is not UNSET_DEFAULT:
+            kwargs["recursive"] = recursive
+        self.__wrapped__.rmdir(**kwargs)
 
     def rename(
         self,
@@ -324,9 +329,14 @@ def rename(
         maxdepth: int | None = UNSET_DEFAULT,
         **kwargs: Any,
     ) -> Self:
+        if recursive is not UNSET_DEFAULT:
+            kwargs["recursive"] = recursive
+        if maxdepth is not UNSET_DEFAULT:
+            kwargs["maxdepth"] = maxdepth
         return self._from_upath(
             self.__wrapped__.rename(
-                target, recursive=recursive, maxdepth=maxdepth, **kwargs
+                target.__wrapped__ if isinstance(target, ProxyUPath) else target,
+                **kwargs,
             )
         )
 

upath/implementations/local.py

@@ -2,6 +2,7 @@
 
 import os
 import pathlib
+import shutil
 import sys
 import warnings
 from collections.abc import Iterator
@@ -316,6 +317,12 @@ def open(
             **fsspec_kwargs,
         )
 
+    def rmdir(self, recursive: bool = UNSET_DEFAULT) -> None:
+        if recursive is UNSET_DEFAULT or not recursive:
+            return super().rmdir()
+        else:
+            shutil.rmtree(self)
+
     if sys.version_info < (3, 14):  # noqa: C901
 
         @overload

upath/types/__init__.py

@@ -61,6 +61,7 @@ class _DefaultValue(enum.Enum):
 #     WritablePath.register(pathlib.Path)
 
 
+@runtime_checkable
 class StatResultType(Protocol):
     """duck-type for os.stat_result"""