fixes

Author: normanrz

upath/core.py

@@ -123,28 +123,28 @@ class UPath(pathlib.Path, PureUPath, metaclass=UPathMeta):
     _default_accessor = _FSSpecAccessor
 
     def __new__(cls, *args, **kwargs):
-        if len(args) == 1 and isinstance(args[0], cls):
-            other = args[0]
-            new_args = (
-                other._format_parsed_parts(
-                    other._drv, other._root, other._parts
-                ),
-            )
-            new_kwargs = {}
-            if hasattr(other, "_kwargs"):
-                new_kwargs = other._kwargs.copy()
+        if issubclass(cls, UPath):
+            args_list = list(args)
+            first = args_list.pop(0)
+            if isinstance(first, pathlib.PurePath):
+                # Create a (modified) copy, if first arg is a Path object
+                other = first
+                parts = args_list
+                drv, root, parts = other._parse_args(parts)
+                drv, root, parts = other._flavour.join_parsed_parts(
+                    other._drv, other._root, other._parts, drv, root, parts
+                )
+
+                new_kwargs = getattr(other, "_kwargs", {}).copy()
                 new_kwargs.pop("_url", None)
+                new_kwargs.update(kwargs)
 
-            return cls.__new__(
-                cls,
-                *new_args,
-                **new_kwargs,
-            )
+                return other.__class__(
+                    other._format_parsed_parts(drv, root, parts),
+                    **new_kwargs,
+                )
 
-        if issubclass(cls, UPath):
-            args_list = list(args)
-            url = args_list.pop(0)
-            url = stringify_path(url)
+            url = stringify_path(first)
             parsed_url = urllib.parse.urlparse(url)
             for key in ["scheme", "netloc"]:
                 val = kwargs.get(key)

upath/tests/test_core.py

@@ -182,6 +182,8 @@ def test_copy_path():
     path = UPath("gcs://bucket/folder", anon=True)
     copy_path = UPath(path)
 
+    print(type(path), type(copy_path))
+
     assert type(path) == type(copy_path)
     assert str(path) == str(copy_path)
     assert path._drv == copy_path._drv
@@ -199,3 +201,26 @@ def test_copy_path_posix():
     assert path._drv == copy_path._drv
     assert path._root == copy_path._root
     assert path._parts == copy_path._parts
+
+
+def test_copy_path_append():
+    path = UPath("/tmp/folder")
+    copy_path = UPath(path, "folder2")
+
+    assert type(path) == type(copy_path) == type(pathlib.Path(""))
+    assert f"{path}/folder2" == str(copy_path)
+
+    path = UPath("/tmp/folder")
+    copy_path = UPath(path, "folder2/folder3")
+
+    assert f"{path}/folder2/folder3" == str(copy_path)
+
+
+def test_copy_path_append_kwargs():
+    path = UPath("gcs://bucket/folder", anon=True)
+    copy_path = UPath(path, anon=False)
+
+    assert type(path) == type(copy_path)
+    assert str(path) == str(copy_path)
+    assert not copy_path._kwargs["anon"]
+    assert path._kwargs["anon"]