Silence various warnings in tests (#267)

* tests: silence various warnings

* tests: silence botocore warning

* ci: update actions

* ci: silence pip error on macos py38

Author: ap--

.github/workflows/release.yml

@@ -13,12 +13,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out the repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
 
     - name: Set up Python 3.10
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: '3.10'
 

.github/workflows/tests.yml

@@ -31,12 +31,14 @@ jobs:
 
     steps:
     - name: Check out the repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
 
     - name: Set up Python ${{ matrix.pyv }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
+      env:
+        PIP_DISABLE_PIP_VERSION_CHECK: ${{ matrix.pyv == '3.8' && matrix.os == 'macos-latest' }}
       with:
         python-version: ${{ matrix.pyv }}
 
@@ -57,7 +59,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Python ${{ matrix.pyv }}
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v5
         with:
           python-version: '3.8'
 
@@ -72,12 +74,12 @@ jobs:
 
     steps:
     - name: Check out the repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
 
     - name: Set up Python ${{ matrix.pyv }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: '3.10'
 
@@ -95,12 +97,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: Check out the repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         fetch-depth: 0
 
     - name: Set up Python ${{ matrix.pyv }}
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: '3.10'
 

upath/tests/implementations/test_http.py

@@ -171,8 +171,8 @@ def test_query_parameters_passthrough():
         ),
         (
             "http://www.example.com/a/b/index.html",
-            "ftp://other.com/image.png",
-            "ftp://other.com/image.png",
+            "sftp://other.com/image.png",
+            "sftp://other.com/image.png",
         ),
         (
             "http://www.example.com/a/b/index.html",

upath/tests/implementations/test_s3.py

@@ -1,6 +1,8 @@
 """see upath/tests/conftest.py for fixtures
 """
 
+import sys
+
 import fsspec
 import pytest  # noqa: F401
 
@@ -10,6 +12,20 @@
 from ..cases import BaseTests
 
 
+def silence_botocore_datetime_deprecation(cls):
+    # botocore uses datetime.datetime.utcnow in 3.12 which is deprecated
+    # see: https://github.com/boto/boto3/issues/3889#issuecomment-1751296363
+    if sys.version_info >= (3, 12):
+        return pytest.mark.filterwarnings(
+            "ignore"
+            r":datetime.datetime.utcnow\(\) is deprecated"
+            ":DeprecationWarning"
+        )(cls)
+    else:
+        return cls
+
+
+@silence_botocore_datetime_deprecation
 class TestUPathS3(BaseTests):
     SUPPORTS_EMPTY_DIRS = False
 
@@ -42,9 +58,9 @@ def test_relative_to(self):
         )
 
     def test_iterdir_root(self):
-        client_kwargs = self.path._kwargs["client_kwargs"]
+        client_kwargs = self.path.storage_options["client_kwargs"]
         bucket_path = UPath("s3://other_test_bucket", client_kwargs=client_kwargs)
-        bucket_path.mkdir(mode="private")
+        bucket_path.mkdir()
 
         (bucket_path / "test1.txt").touch()
         (bucket_path / "test2.txt").touch()

upath/tests/implementations/test_webdav.py

@@ -1,10 +1,25 @@
-import pytest  # noqa: F401
+import sys
+
+import pytest
 
 from upath import UPath
 
 from ..cases import BaseTests
 
 
+def silence_wsigdav_deprecation(cls):
+    # wsgidav deprecated python 3.8 while still shipping versions supporting it?
+    if sys.version_info < (3, 9):
+        return pytest.mark.filterwarnings(
+            "ignore"
+            ":Support for Python version less than `3.9` is deprecated"
+            ":DeprecationWarning"
+        )(cls)
+    else:
+        return cls
+
+
+@silence_wsigdav_deprecation
 class TestUPathWebdav(BaseTests):
     @pytest.fixture(autouse=True, scope="function")
     def path(self, webdav_fixture):

upath/tests/pathlib/conftest.py

@@ -14,7 +14,7 @@
 }
 
 
-def pytest_ignore_collect(collection_path, path, config):
+def pytest_ignore_collect(collection_path):
     """prevents pathlib tests from other python version than the current to be collected
 
     (otherwise we see a lot of skipped tests in the pytest output)

upath/tests/test_core.py

@@ -99,7 +99,10 @@ def test_subclass(local_testdir):
     class MyPath(UPath):
         pass
 
-    path = MyPath(local_testdir)
+    with pytest.warns(
+        DeprecationWarning, match=r"MyPath\(...\) detected protocol '' .*"
+    ):
+        path = MyPath(local_testdir)
     assert str(path) == str(pathlib.Path(local_testdir))
     assert issubclass(MyPath, UPath)
     assert isinstance(path, pathlib.Path)
@@ -285,13 +288,16 @@ def __fspath__(self):
 def test_access_to_private_kwargs_and_url(urlpath):
     # fixme: this should be deprecated...
     pth = UPath(urlpath)
-    assert isinstance(pth._kwargs, Mapping)
-    assert pth._kwargs == {}
+    with pytest.warns(DeprecationWarning, match="UPath._kwargs is deprecated"):
+        assert isinstance(pth._kwargs, Mapping)
+    with pytest.warns(DeprecationWarning, match="UPath._kwargs is deprecated"):
+        assert pth._kwargs == {}
     assert isinstance(pth._url, SplitResult)
     assert pth._url.scheme == "" or pth._url.scheme in pth.fs.protocol
     assert pth._url.path == pth.path
     subpth = pth / "foo"
-    assert subpth._kwargs == {}
+    with pytest.warns(DeprecationWarning, match="UPath._kwargs is deprecated"):
+        assert subpth._kwargs == {}
     assert isinstance(subpth._url, SplitResult)
     assert subpth._url.scheme == "" or subpth._url.scheme in subpth.fs.protocol
     assert subpth._url.path == subpth.path