linting and improved nox

Author: andrewfulton9

.flake8

@@ -0,0 +1,14 @@
+[flake8]
+max-line-length = 80
+per-file-ignores =
+    upath/__init__.py: F401
+exclude =
+    .noxfile,
+    .nox,
+    __pycache__,
+    .git,
+    .github,
+    .gitignore,
+    .pytest_cache,
+    
+    

environment.yml

@@ -18,4 +18,5 @@ dependencies:
     - pip
     - pip:
       - hadoop-test-cluster
+      - nox
 

noxfile.py

@@ -1,4 +1,5 @@
 import nox
+from pathlib import Path
 
 
 @nox.session(python=False)
@@ -10,13 +11,13 @@ def develop(session):
 @nox.session(python=False)
 def black(session):
     session.install("black")
-    session.run(*"black upath".split())
+    session.run(*"black upath noxfile.py setup.py".split())
 
 
 @nox.session(python=False)
 def lint(session):
     session.install("flake8")
-    session.run(*"flake8 upath".split())
+    session.run(*"flake8".split())
 
 
 @nox.session(python=False)
@@ -34,3 +35,12 @@ def smoke(session):
 def build(session):
     session.install("flit")
     session.run(*"flit build".split())
+
+
+@nox.session(python=False)
+def rm_dirs(session):
+    paths = ["build", "dist"]
+    for path in paths:
+        p = Path(path)
+        if p.exists():
+            session.run(*f"rm -rf {str(p)}".split())

setup.py

@@ -4,7 +4,7 @@
 
 with open("README.md") as f:
     long_description = f.read()
-    
+
 setuptools.setup(
     name="universal_pathlib",
     version=__version__,
@@ -15,5 +15,5 @@
     python_requires=">=3.7",
     description="pathlib api extended to use fsspec backends",
     long_description=long_description,
-    long_description_content_type='text/markdown'
+    long_description_content_type="text/markdown",
 )

upath/core.py

@@ -1,15 +1,9 @@
 import os
 import pathlib
-from pathlib import *
 import urllib
 import re
-import asyncio
-import inspect
 
-import fsspec
-from fsspec.asyn import AsyncFileSystem
-from fsspec.core import url_to_fs
-from fsspec.registry import filesystem, get_filesystem_class
+from fsspec.registry import get_filesystem_class
 
 from upath.errors import NotDirectoryError
 
@@ -81,21 +75,18 @@ def __getattribute__(self, item):
         if fs is not None:
             method = getattr(fs, item, None)
             if method:
-                awaitable = inspect.isawaitable(
-                    lambda args, kwargs: method(*args, **kwargs)
-                )
-                return lambda *args, **kwargs: self.argument_upath_self_to_filepath(
-                    method
-                )(
-                    *args, **kwargs
-                )
+                return lambda *args, **kwargs: (
+                    self.argument_upath_self_to_filepath(method)(
+                        *args, **kwargs
+                    )
+                )  # noqa: E501
             else:
                 raise NotImplementedError(
                     f"{fs.protocol} filesystem has not attribute {item}"
                 )
 
 
-class PureUniversalPath(PurePath):
+class PureUniversalPath(pathlib.PurePath):
     _flavour = pathlib._posix_flavour
     __slots__ = ()
 
@@ -111,7 +102,11 @@ def __new__(cls, *args, **kwargs):
                 if val:
                     parsed_url._replace(**{key: val})
             if not parsed_url.scheme:
-                cls = WindowsPath if os.name == "nt" else PosixPath
+                cls = (
+                    pathlib.WindowsPath
+                    if os.name == "nt"
+                    else pathlib.PosixPath
+                )
             else:
                 cls = UniversalPath
                 # cls._url = parsed_url
@@ -134,28 +129,6 @@ def __new__(cls, *args, **kwargs):
         return self
 
 
-def run_as_async(self, func, *args, **kwargs):
-    def wrapper(*args, **kwargs):
-        if isinstance(self.fs, AsyncFileSystem):
-            result = None
-
-            async def async_runner():
-                async def async_func():
-                    return await func(*args, **kwargs)
-
-                coro = async_func()
-                done, pending = await asyncio.wait({coro})
-                if coro is done:
-                    result = coro
-
-            asyncio.run(async_runner())
-            return result
-        else:
-            return func(*args, **kwargs)
-
-    return wrapper
-
-
 class UniversalPath(UPath, PureUniversalPath):
 
     __slots__ = ("_url", "_kwargs", "_closed", "fs")
@@ -298,20 +271,15 @@ def unlink(self, missing_ok=False):
                 raise FileNotFoundError
             else:
                 return
-        try:
-            self._accessor.rm(self, recursive=False)
-        except:
-            self._accessor.rm_file(self)
-
-        # asyncio.run(async_unlink())
+        self._accessor.rm(self, recursive=False)
 
     def rmdir(self, recursive=True):
         """Add warning if directory not empty
         assert is_dir?
         """
         try:
             assert self.is_dir()
-        except:
+        except AssertionError:
             raise NotDirectoryError
         self._accessor.rm(self, recursive=recursive)
 

upath/tests/test_core.py

@@ -226,13 +226,13 @@ def test_mkdir(self):
         # new_dir.mkdir()
         # mkdir doesnt really do anything. A directory only exists in s3
         # if some file or something is written to it
-        f = new_dir.joinpath("test.txt").touch()
+        new_dir.joinpath("test.txt").touch()
         assert new_dir.exists()
 
     def test_rmdir(self, local_testdir):
         dirname = "rmdir_test"
         mock_dir = self.path.joinpath(dirname)
-        f = mock_dir.joinpath("test.txt").touch()
+        mock_dir.joinpath("test.txt").touch()
         mock_dir.rmdir()
         assert not mock_dir.exists()
         with pytest.raises(NotDirectoryError):
@@ -261,5 +261,5 @@ def test_multiple_backend_paths(local_testdir, s3, hdfs):
     assert s3_path.joinpath("text.txt")._url.scheme == "s3"
     host, user, port = hdfs
     path = f"hdfs:{local_testdir}"
-    hdfs_path = UPath(path, host=host, user=user, port=port)
+    UPath(path, host=host, user=user, port=port)
     assert s3_path.joinpath("text1.txt")._url.scheme == "s3"