Merge pull request #53 from scalableminds/is_symlink_false

Adds default implementations for is_symlink etc.

Author: andrewfulton9

upath/core.py

@@ -109,12 +109,6 @@ class UPath(pathlib.Path, PureUPath, metaclass=UPathMeta):
         "home",
         "expanduser",
         "group",
-        "is_mount",
-        "is_symlink",
-        "is_socket",
-        "is_fifo",
-        "is_block_device",
-        "is_char_device",
         "lchmod",
         "lstat",
         "owner",
@@ -288,6 +282,27 @@ def is_file(self):
             return True
         return False
 
+    def is_mount(self):
+        return False
+
+    def is_symlink(self):
+        info = self._accessor.info(self)
+        if "islink" in info:
+            return info["islink"]
+        return False
+
+    def is_socket(self):
+        return False
+
+    def is_fifo(self):
+        return False
+
+    def is_block_device(self):
+        return False
+
+    def is_char_device(self):
+        return False
+
     def chmod(self, mod):
         raise NotImplementedError
 

upath/tests/cases.py

@@ -62,28 +62,22 @@ def test_is_file(self):
         assert not self.path.is_file()
 
     def test_is_mount(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_mount()
+        assert self.path.is_mount() is False
 
     def test_is_symlink(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_symlink()
+        assert self.path.is_symlink() is False
 
     def test_is_socket(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_socket()
+        assert self.path.is_socket() is False
 
     def test_is_fifo(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_fifo()
+        assert self.path.is_fifo() is False
 
     def test_is_block_device(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_block_device()
+        assert self.path.is_block_device() is False
 
     def test_is_char_device(self):
-        with pytest.raises(NotImplementedError):
-            self.path.is_char_device()
+        assert self.path.is_char_device() is False
 
     def test_iterdir(self, local_testdir):
         pl_path = Path(local_testdir)