Skip to content

Commit bcf48c3

Browse files
committed
fixed some issues with URDF export in regards to robot_description
1 parent 152d409 commit bcf48c3

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

Runtime/Scripts/Util/ImportExport/ZOExportURDF.cs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ protected void BuildURDFJoints(XElement robot, ZOSimOccurrence parent, ZOSimOccu
222222
foreach (ZOJointInterface joint in zoJoints) {
223223
if (joint.ConnectedOccurrence == child) { // only if this joint is pointing at us
224224
XElement jointX = new XElement("joint");
225-
jointX.SetAttributeValue("name", $"{joint.Type}_{parent.Name}_to_{child.Name}");
225+
jointX.SetAttributeValue("name", $"{joint.Name}");
226226
// Transform jointTransform = this.transform;
227227
Matrix4x4 jointMatrix = Matrix4x4.identity;
228228

@@ -241,8 +241,12 @@ protected void BuildURDFJoints(XElement robot, ZOSimOccurrence parent, ZOSimOccu
241241
// create limits
242242
// TODO:
243243
XElement limitX = new XElement("limit");
244-
limitX.SetAttributeValue("effort", 10000f); // HACK
245-
limitX.SetAttributeValue("velocity", 3.14f); // HACK
244+
limitX.SetAttributeValue("effort", 330.0f); // HACK
245+
limitX.SetAttributeValue("velocity", 2.16f); // HACK
246+
limitX.SetAttributeValue("lower", -6.28318530718); // HACK
247+
limitX.SetAttributeValue("upper", 6.28318530718); // HACK
248+
limitX.SetAttributeValue("velocity", 2.16f); // HACK
249+
246250
jointX.Add(limitX);
247251

248252
// Add the anchor position

0 commit comments

Comments
 (0)