Skip to content

Commit df37a2c

Browse files
committed
fixed odometry pose to match TF
1 parent 327c774 commit df37a2c

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Runtime/Scripts/ROS/MessageTypes/Geometry/ZOROSGeometryMessages.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -424,29 +424,29 @@ public PoseMessage(PointMessage position, QuaternionMessage orientation) {
424424
/// Does Unity to ROS coordinate system transform.
425425
/// </summary>
426426
/// <param name="transform"></param>
427-
public void FromLocalUnityTransform(UnityEngine.Transform transform) {
427+
public void FromLocalUnityTransformToROS(UnityEngine.Transform transform) {
428428
this.position.UnityVector3 = transform.localPosition;
429429
this.orientation.UnityQuaternion = transform.localRotation;
430430
}
431431

432432
[Newtonsoft.Json.JsonIgnore]
433433
public UnityEngine.Transform LocalUnityTransform {
434-
set { FromLocalUnityTransform(value); }
434+
set { FromLocalUnityTransformToROS(value); }
435435
}
436436

437437
/// <summary>
438438
/// Convert global Unity Transform to ROS Pose.
439439
/// Does Unity to ROS coordinate system transform.
440440
/// </summary>
441441
/// <param name="transform"></param>
442-
public void FromGlobalUnityTransform(UnityEngine.Transform transform) {
442+
public void FromGlobalUnityTransformToROS(UnityEngine.Transform transform) {
443443
this.position.UnityVector3 = transform.position;
444444
this.orientation.UnityQuaternion = transform.rotation;
445445
}
446446

447447
[Newtonsoft.Json.JsonIgnore]
448448
public UnityEngine.Transform GlobalUnityTransform {
449-
set { FromGlobalUnityTransform(value); }
449+
set { FromGlobalUnityTransformToROS(value); }
450450
}
451451

452452
}

Runtime/Scripts/ROS/Unity/Publishers/ZOROSFakeOdometryPublisher.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,15 @@ protected override void ZOFixedUpdateHzSynchronized() {
6969
_transformStampedMessage.header.Update();
7070
_transformStampedMessage.header.frame_id = ZOROSUnityManager.Instance.WorldFrameId; // connect to the world
7171
_transformStampedMessage.child_frame_id = "odom";
72-
_transformStampedMessage.UnityLocalTransform = Rigidbody.transform;
72+
_transformStampedMessage.FromLocalUnityTransformToROS(Rigidbody.transform);
7373
ZOROSUnityManager.Instance.BroadcastTransform(_transformStampedMessage);
7474

7575

7676
_currentOdometryMessage.Update(); // update times stamps
7777

7878
// BUGBUG: not super clear on where the pose should be?
79-
_currentOdometryMessage.pose.pose.GlobalUnityTransform = Rigidbody.transform;
79+
// _currentOdometryMessage.pose.pose.GlobalUnityTransform = Rigidbody.transform;
80+
_currentOdometryMessage.pose.pose.FromLocalUnityTransformToROS(Rigidbody.transform);
8081

8182
// get velocity in /odom frame
8283
Vector3 linear = Rigidbody.velocity;

0 commit comments

Comments
 (0)