Skip to content

Commit fb6b5d0

Browse files
fix(kcm): resolve EditorTab KeySequenceInput clash; fix(kwin): remove explicit KPlugin Id
- KCM: use unique type PlasmaZonesKeySequenceInput so EditorTab always gets our component (with defaultKeySequence); avoids 'non-existent property' when QML is loaded from system path (e.g. NixOS) - KCM: single qmldir entry for PlasmaZonesKeySequenceInput; update comment in ModifierAndMouseCheckBoxes.qml - KWin effect: remove Id from metadata.json to satisfy KPlugin loader (id derived from filename) Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent c2aee6a commit fb6b5d0

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

kcm/ui/ModifierAndMouseCheckBoxes.qml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Item {
7373
{ bit: 0x80, label: i18n("Extra 5") }
7474
]
7575

76-
// Match KeySequenceInput: no fixed width so FormLayout gives same column width as shortcut fields
76+
// Match PlasmaZonesKeySequenceInput: no fixed width so FormLayout gives same column width as shortcut fields
7777
implicitWidth: allowMultiple ? multiContainer.implicitWidth : field.implicitWidth
7878
implicitHeight: allowMultiple ? multiContainer.implicitHeight : field.implicitHeight
7979

kcm/ui/qmldir

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ AssignmentRow 1.0 AssignmentRow.qml
22
ColorButton 1.0 ColorButton.qml
33
FontPickerDialog 1.0 FontPickerDialog.qml
44
InputCapture 1.0 InputCapture.qml
5-
KeySequenceInput 1.0 KeySequenceInput.qml
5+
PlasmaZonesKeySequenceInput 1.0 KeySequenceInput.qml
66
LayoutComboBox 1.0 LayoutComboBox.qml
77
LayoutThumbnail 1.0 LayoutThumbnail.qml
88
ModifierAndMouseCheckBoxes 1.0 ModifierAndMouseCheckBoxes.qml

kcm/ui/tabs/EditorTab.qml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ ScrollView {
4343
}
4444

4545
contentItem: Kirigami.FormLayout {
46-
KeySequenceInput {
46+
PlasmaZonesKeySequenceInput {
4747
id: editorDuplicateShortcutField
4848
Layout.fillWidth: true
4949
Kirigami.FormData.label: i18n("Duplicate zone:")
@@ -56,7 +56,7 @@ ScrollView {
5656
ToolTip.text: i18n("Keyboard shortcut to duplicate the selected zone")
5757
}
5858

59-
KeySequenceInput {
59+
PlasmaZonesKeySequenceInput {
6060
id: editorSplitHorizontalShortcutField
6161
Layout.fillWidth: true
6262
Kirigami.FormData.label: i18n("Split horizontally:")
@@ -69,7 +69,7 @@ ScrollView {
6969
ToolTip.text: i18n("Keyboard shortcut to split selected zone horizontally")
7070
}
7171

72-
KeySequenceInput {
72+
PlasmaZonesKeySequenceInput {
7373
id: editorSplitVerticalShortcutField
7474
Layout.fillWidth: true
7575
Kirigami.FormData.label: i18n("Split vertically:")
@@ -82,7 +82,7 @@ ScrollView {
8282
ToolTip.text: i18n("Keyboard shortcut to split selected zone vertically")
8383
}
8484

85-
KeySequenceInput {
85+
PlasmaZonesKeySequenceInput {
8686
id: editorFillShortcutField
8787
Layout.fillWidth: true
8888
Kirigami.FormData.label: i18n("Fill space:")

kwin-effect/metadata.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"Category": "Window Management",
44
"Description": "FancyZones-style window snapping with modifier key detection",
55
"EnabledByDefault": true,
6-
"Id": "plasmazones",
76
"License": "GPL",
87
"Name": "PlasmaZones",
98
"Authors": [

0 commit comments

Comments
 (0)