Skip to content

Commit cc87d70

Browse files
committed
Code cleanups.
1 parent 582faca commit cc87d70

File tree

2 files changed

+30
-23
lines changed

2 files changed

+30
-23
lines changed

Console.pde

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ class Console {
88
HashMap<String, Controller> widgets;
99
HashMap<Integer, String> id2parameter;
1010
Settings settings;
11+
int lastWidget_y;
1112

1213
Console(PApplet parent, int x, int y, int w, int h, Settings settings) {
1314
this.x = x;
@@ -86,41 +87,34 @@ class Console {
8687
.setPosition(x + 140, y + 230)
8788
.setSize(80, 20)
8889
.setRange(1, 80));
89-
widgets.put("jumpPower", ctlr.addSlider("Jump Velocity")
90-
.setPosition(x + 10, y + 260)
90+
lastWidget_y = y + 230;
91+
appendFullwidthWidget("jumpPower", ctlr.addSlider("Jump Velocity")
9192
.setSize(150, 20)
9293
.setRange(1, 30));
93-
widgets.put("jumpAnticipationFrames", ctlr.addSlider("Jump Anticipation Frames")
94-
.setPosition(x + 10, y + 290)
94+
appendFullwidthWidget("jumpAnticipationFrames", ctlr.addSlider("Jump Anticipation Frames")
9595
.setSize(150, 20)
9696
.setRange(1, 10)
97-
.setNumberOfTickMarks(10));
98-
widgets.put("gravity", ctlr.addSlider("Gravity (rising)")
99-
.setPosition(x + 10, y + 320)
97+
.setNumberOfTickMarks(10)
98+
.showTickMarks(false));
99+
appendFullwidthWidget("gravity", ctlr.addSlider("Gravity (rising)")
100100
.setSize(150, 20)
101101
.setRange(0, 3));
102-
widgets.put("gravityFalling", ctlr.addSlider("Gravity (falling)")
103-
.setPosition(x + 10, y + 350)
102+
appendFullwidthWidget("gravityFalling", ctlr.addSlider("Gravity (falling)")
104103
.setSize(150, 20)
105104
.setRange(0.01, 3));
106-
widgets.put("axNormal", ctlr.addSlider("X Accel (normal)")
107-
.setPosition(x + 10, y + 380)
105+
appendFullwidthWidget("axNormal", ctlr.addSlider("X Accel (normal)")
108106
.setSize(150, 20)
109107
.setRange(0, 3));
110-
widgets.put("axBreak", ctlr.addSlider("X Accel (breaking)")
111-
.setPosition(x + 10, y + 410)
108+
appendFullwidthWidget("axBreak", ctlr.addSlider("X Accel (breaking)")
112109
.setSize(150, 20)
113110
.setRange(0, 3));
114-
widgets.put("axJumping", ctlr.addSlider("X Accel (jumping)")
115-
.setPosition(x + 10, y + 440)
111+
appendFullwidthWidget("axJumping", ctlr.addSlider("X Accel (jumping)")
116112
.setSize(150, 20)
117113
.setRange(0, 3));
118-
widgets.put("camEasingNormal", ctlr.addSlider("Camera Easing Coef (normal)")
119-
.setPosition(x + 10, y + 470)
114+
appendFullwidthWidget("camEasingNormal", ctlr.addSlider("Camera Easing Coef (normal)")
120115
.setSize(150, 20)
121116
.setRange(0, 1));
122-
widgets.put("camEasingGrounding", ctlr.addSlider("Camera Easing Coef (grounding)")
123-
.setPosition(x + 10, y + 500)
117+
appendFullwidthWidget("camEasingGrounding", ctlr.addSlider("Camera Easing Coef (grounding)")
124118
.setSize(150, 20)
125119
.setRange(0, 1));
126120

@@ -147,6 +141,12 @@ class Console {
147141
);
148142
}
149143

144+
void appendFullwidthWidget(String name, Controller widget) {
145+
lastWidget_y += 30;
146+
widget.setPosition(x + 10, lastWidget_y);
147+
widgets.put(name, widget);
148+
}
149+
150150
void statusUpdate(Jumper jumper) {
151151
((Textlabel)widgets.get("JumperXYvalue")).setText(String.format("%4.2f,%4.2f", jumper.x, jumper.y));
152152
((Textlabel)widgets.get("JumperVXYvalue")).setText(String.format("%-2.2f,%-2.2f", jumper.vx, jumper.vy));

jumplab.pde

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,22 @@ Level level;
44
Camera camera;
55
Console console;
66

7-
void setup() {
8-
size(1100, 600, P2D);
7+
static final int gameScreen_w = 800;
8+
static final int gameScreen_h = 600;
9+
static final int console_w = 300;
10+
11+
void settings() {
12+
size(gameScreen_w + console_w, gameScreen_h, P2D);
13+
}
914

15+
void setup() {
16+
noSmooth();
1017
settings = new Settings();
1118
masao = new Jumper(settings, 48, 950);
1219
level = new Level("level1.csv", "block.png", "bg.png");
13-
camera = new Camera(masao, level, 800, 600);
20+
camera = new Camera(masao, level, gameScreen_w, gameScreen_h);
1421
camera.reset(masao.x, masao.y);
15-
console = new Console(this, camera.window_w, 0, width - camera.window_w, camera.window_h, settings);
22+
console = new Console(this, gameScreen_w, 0, console_w, gameScreen_h, settings);
1623
frameRate(60);
1724
background(128);
1825
}

0 commit comments

Comments
 (0)