-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
agent-generatedCreated by Claude from expert reviewCreated by Claude from expert reviewenhancementNew feature or requestNew feature or requestpriority:mediumMedium priorityMedium prioritytestingTest coverage and qualityTest coverage and quality
Description
Source: Expert Software Review (2026-02-17) — Testing for Software Correctness
Description
MetricWriter currently has only 1 test (test_writer in tests/test_metric_writer.py). This covers basic write with the default tab delimiter but leaves several code paths untested.
Acceptance Criteria
- Test for writing with custom delimiter (
delimiter=",") - Test for
writeall()method standalone - Test for writing metrics with field aliases (
Field(alias=...)) - Test for writing metrics with
Counter[StrEnum]fields (pivot columns in output) - Test for
close()behavior (file handle actually closed) - Test for context manager exception handling (file closed on error)
Issue ID: ISS-002
Created from: agent_notes/issues/issues_2026-02-17_fgmetric_review.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
agent-generatedCreated by Claude from expert reviewCreated by Claude from expert reviewenhancementNew feature or requestNew feature or requestpriority:mediumMedium priorityMedium prioritytestingTest coverage and qualityTest coverage and quality