Add panic message to description and avoid Headers duplication

Author: fulldump

.gitignore

@@ -3,3 +3,5 @@ _vendor/bin
 _vendor/pkg
 _vendor/src/example
 _vendor/src/github.com/fulldump/*
+
+.idea

api.go

@@ -1,6 +1,7 @@
 package golax
 
 import (
+	"fmt"
 	"log"
 	"net/http"
 	"os"
@@ -46,7 +47,7 @@ func (a *Api) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	defer func(c *Context) {
 		if r := recover(); r != nil {
-			c.Error(http.StatusInternalServerError, string(debug.Stack()))
+			c.Error(http.StatusInternalServerError, fmt.Sprintln(r)+string(debug.Stack()))
 			a.Handler500(c)
 		}
 	}(c)

extended_writer.go

@@ -7,13 +7,14 @@ import "net/http"
  * It wraps http.ResponseWriter to add: StatusCode & Length
  */
 type ExtendedWriter struct {
-	StatusCode int
-	Length     int
+	StatusCode     int
+	statusCodeSent bool
+	Length         int
 	http.ResponseWriter
 }
 
 func NewExtendedWriter(w http.ResponseWriter) *ExtendedWriter {
-	return &ExtendedWriter{200, 0, w}
+	return &ExtendedWriter{200, false, 0, w}
 }
 
 func (this *ExtendedWriter) Write(p []byte) (int, error) {
@@ -24,5 +25,8 @@ func (this *ExtendedWriter) Write(p []byte) (int, error) {
 
 func (this *ExtendedWriter) WriteHeader(statusCode int) {
 	this.StatusCode = statusCode
-	this.ResponseWriter.WriteHeader(statusCode)
+	if !this.statusCodeSent {
+		this.ResponseWriter.WriteHeader(statusCode)
+		this.statusCodeSent = true
+	}
 }

extended_writer_test.go

@@ -0,0 +1,63 @@
+package golax
+
+import (
+	"encoding/json"
+	"fmt"
+	"reflect"
+	"strings"
+	"testing"
+)
+
+func Test_ExtendedWriter_WriteTwice(t *testing.T) {
+	world := NewWorld()
+	defer world.Destroy()
+
+	world.Api.Handler500 = func(c *Context) {
+		json.NewEncoder(c.Response).Encode(map[string]interface{}{
+			"status":      c.LastError.StatusCode,
+			"description": c.LastError.Description,
+		})
+	}
+
+	world.Api.Root.
+		Interceptor(InterceptorError).
+		Node("example").
+		Method("GET", func(c *Context) {
+			c.Response.WriteHeader(400)
+			c.Response.WriteHeader(401)
+
+			c.Response.Write([]byte("Hello\n"))
+			panic("This is a panic!")
+			c.Response.Write([]byte("world"))
+
+		})
+
+	fmt.Println("=============================================")
+
+	res := world.Request("GET", "/example").Do()
+
+	if 400 != res.StatusCode {
+		t.Error("Status code should be 400")
+	}
+
+	body := res.BodyString()
+
+	body_lines := strings.Split(body, "\n")
+
+	if "Hello" != body_lines[0] {
+		t.Error("First line should be `Hello` instead of " + body_lines[0])
+	}
+
+	body_json := map[string]interface{}{}
+
+	json.Unmarshal([]byte(body_lines[1]), &body_json)
+
+	if !reflect.DeepEqual(float64(500), body_json["status"]) {
+		t.Error("Body json status should be status:500")
+	}
+
+	if !strings.HasPrefix(body_json["description"].(string), "This is a panic!") {
+		t.Error("Body json description should start by `This is a panic!` ")
+	}
+
+}