Fix upgrade bootstrap: publish legacy darwin/win32 asset aliases and add fallback in selectAsset

Old binaries (<=v1.1.0) look for 'github-code-search-darwin-arm64' in the release
assets, but since v1.2.0 the CD pipeline only produces 'github-code-search-macos-arm64'.
This creates a bootstrap failure: already-installed binaries cannot upgrade themselves.

Two complementary fixes:
- cd.yaml: after downloading artifacts, copy macos-*/windows-* to darwin-*/win32-*
  so that every release contains both naming conventions going forward.
- upgrade.ts (selectAsset): try the canonical mapped name first (macos-arm64), then
  fall back to the raw Node.js platform name (darwin-arm64) for resilience.

Closes #45.

Author: shouze

.github/workflows/cd.yaml

@@ -83,6 +83,14 @@ jobs:
           path: dist/
           merge-multiple: true
 
+      - name: Create legacy artifact aliases (backward-compat for upgrade)
+        # Fix: binaries built before v1.2.1 look for darwin-* / win32-* asset names.
+        # Publishing these aliases lets old binaries upgrade themselves — see issue #45.
+        run: |
+          cp dist/github-code-search-macos-arm64 dist/github-code-search-darwin-arm64
+          cp dist/github-code-search-macos-x64 dist/github-code-search-darwin-x64
+          cp dist/github-code-search-windows-x64.exe dist/github-code-search-win32-x64.exe
+
       - name: Create release
         uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b # v2.5.0
         with:

src/upgrade.test.ts

@@ -93,6 +93,40 @@ describe("selectAsset", () => {
   it("returns null for empty asset list", () => {
     expect(selectAsset([], "darwin", "arm64")).toBeNull();
   });
+
+  describe("legacy fallback (pre-v1.2.1 asset names)", () => {
+    const legacyAssets: ReleaseAsset[] = [
+      makeAsset("github-code-search-darwin-arm64"),
+      makeAsset("github-code-search-darwin-x64"),
+      makeAsset("github-code-search-linux-x64"),
+      makeAsset("github-code-search-linux-arm64"),
+      makeAsset("github-code-search-win32-x64.exe"),
+    ];
+
+    it("falls back to darwin-arm64 when macos-arm64 is absent", () => {
+      const asset = selectAsset(legacyAssets, "darwin", "arm64");
+      expect(asset?.name).toBe("github-code-search-darwin-arm64");
+    });
+
+    it("falls back to darwin-x64 when macos-x64 is absent", () => {
+      const asset = selectAsset(legacyAssets, "darwin", "x64");
+      expect(asset?.name).toBe("github-code-search-darwin-x64");
+    });
+
+    it("falls back to win32-x64.exe when windows-x64.exe is absent", () => {
+      const asset = selectAsset(legacyAssets, "win32", "x64");
+      expect(asset?.name).toBe("github-code-search-win32-x64.exe");
+    });
+
+    it("prefers canonical macos-arm64 over legacy darwin-arm64 when both present", () => {
+      const mixed = [
+        makeAsset("github-code-search-darwin-arm64"),
+        makeAsset("github-code-search-macos-arm64"),
+      ];
+      const asset = selectAsset(mixed, "darwin", "arm64");
+      expect(asset?.name).toBe("github-code-search-macos-arm64");
+    });
+  });
 });
 
 // ─── fetchLatestRelease ─────────────────────────────────────────────────────

src/upgrade.ts

@@ -44,17 +44,27 @@ export function isNewerVersion(current: string, latest: string): boolean {
  * Node.js/Bun platform names are mapped to artifact names:
  *   darwin → macos
  *   win32  → windows
+ *
+ * A legacy fallback also tries the raw Node.js platform name (darwin, win32)
+ * so that binaries built before v1.2.1 can still upgrade themselves.
  */
 export function selectAsset(
   assets: ReleaseAsset[],
   platform: string,
   arch: string,
 ): ReleaseAsset | null {
-  const platformMap: Record<string, string> = { darwin: "macos", win32: "windows" };
+  const platformMap: Record<string, string> = {
+    darwin: "macos",
+    win32: "windows",
+  };
   const artifactPlatform = platformMap[platform] ?? platform;
   const suffix = artifactPlatform === "windows" ? ".exe" : "";
   const name = `github-code-search-${artifactPlatform}-${arch}${suffix}`;
-  return assets.find((a) => a.name === name) ?? null;
+  // Fix: fall back to legacy platform names (darwin, win32) published alongside
+  // the canonical names for backward-compat with pre-v1.2.1 binaries — see issue #45
+  const legacySuffix = platform === "win32" ? ".exe" : "";
+  const legacyName = `github-code-search-${platform}-${arch}${legacySuffix}`;
+  return assets.find((a) => a.name === name) ?? assets.find((a) => a.name === legacyName) ?? null;
 }
 
 // ─── GitHub API ───────────────────────────────────────────────────────────────