Add some more tests

Author: wilr

phpunit.xml.dist

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Standard module phpunit configuration.
+Requires PHPUnit ^5.7
+-->
+<phpunit bootstrap="vendor/silverstripe/framework/tests/bootstrap.php" colors="true">
+    <testsuite name="Default">
+        <directory>tests</directory>
+    </testsuite>
+</phpunit>

src/AddressFinderField.php

@@ -97,16 +97,27 @@ public function __construct($name, $title = null, $value = null)
         parent::__construct($name, $title, $value);
     }
 
+    /**
+     * @param bool $bool
+     *
+     * @return $this
+     */
     public function setShowLatLngManual($bool)
     {
         $this->showLatLngManual = $bool;
 
         return $this;
     }
 
+    /**
+     * @param bool $bool
+     *
+     * @return $this
+     */
     public function setRequireLatLngManual($bool)
     {
         $this->requireLatLngManual = $bool;
+        $this->showLatLngManual = true;
 
         return $this;
     }
@@ -115,7 +126,7 @@ public function setRequireLatLngManual($bool)
     /**
      * @param bool $bool
      *
-     * @return void
+     * @return $this
      */
     public function setReadonly($bool)
     {
@@ -131,6 +142,8 @@ public function setReadonly($bool)
     /**
      * @param string $message
      * @param string $messageType
+     *
+     * @return $this
      */
     public function setError($message, $messageType)
     {
@@ -148,7 +161,7 @@ public function setError($message, $messageType)
     }
 
     /**
-     * @return void
+     * @return $this
      */
     public function performReadonlyTransformation()
     {
@@ -167,7 +180,9 @@ public function performReadonlyTransformation()
     }
 
     /**
+     * @param bool $bool
      *
+     * @return $this
      */
     public function setDisabled($bool)
     {
@@ -232,7 +247,7 @@ public function FieldHolder($properties = array())
     }
 
     /**
-     *
+     * @return string
      */
     public function getApiKey()
     {

tests/AddressFinderFieldTest.php

@@ -3,6 +3,7 @@
 namespace FullscreenInteractive\SilverStripe\Tests;
 
 use SilverStripe\Dev\SapphireTest;
+use SilverStripe\Forms\RequiredFields;
 use FullscreenInteractive\SilverStripe\AddressFinderField;
 
 class AddressFinderFieldTest extends SapphireTest
@@ -11,7 +12,34 @@ public function testConstructor()
     {
         $field = new AddressFinderField('name', 'Title');
 
-        $this->assertEquals('Title', $field->getTitle());
-        $this->assertEquals(6, $field->getManualFields()->count());
+        $this->assertEquals('Title', $field->Title());
+        $this->assertEquals(11, $field->getManualFields()->count(), '11 address fields');
+    }
+
+    public function testSetRequireLatLngManual()
+    {
+        $field = new AddressFinderField('name', 'Title');
+        $field = $field->setRequireLatLngManual(true);
+
+        $fieldHolder = $field->FieldHolder();
+
+        $this->assertContains('input type="text" name="name[Longitude]"', $fieldHolder);
+    }
+
+    public function testValidator()
+    {
+        $field = new AddressFinderField('name', 'Title');
+        $required = new RequiredFields('name');
+
+        $this->assertFalse($field->validate($required));
+
+        $field->setValue([
+            'Address' => '1 Test Street, Test Land, 90210',
+            'PostalLine1' => '1 Test Street',
+            'City' => 'Test Land',
+            'Postcode' => '90210'
+        ]);
+
+        $this->assertTrue($field->validate($required));
     }
 }