Skip to content

Commit 4a2b2e6

Browse files
author
adunn
committed
ss4upgrade: removed commented out code and obsolete comments.
1 parent 51f9ee1 commit 4a2b2e6

File tree

1 file changed

+4
-22
lines changed

1 file changed

+4
-22
lines changed

javascript/ImageSelect.jquery.js

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,10 @@
6363
var text = $(option).text();
6464

6565
if(selected && img_src){
66-
6766
var template = html_template.replace('{url}',img_src);
68-
6967
if(spans.length){
7068
for (var j = 0; j < spans.length; j++)
71-
if(text == $(spans[j]).text()){
69+
if(text === $(spans[j]).text()){
7270
$(spans[j]).prepend(template.replace('{class_name}','chose-image'));
7371
}
7472
} else {
@@ -103,14 +101,14 @@
103101
var chosen = self.chosen;
104102
var options = chosen.form_field.options;
105103

106-
if(selected != undefined && selected.selected != undefined && options && options.length){
104+
if(selected !== undefined && selected.selected !== undefined && options && options.length){
107105

108106
for(var i = 0 ; i < options.length; i++){
109107
var option = options[i];
110108
var value = ($(option).attr('value')) ? $(option).attr('value') : $(option).text();
111109
var img_src = $(option).attr('data-img-src');
112110

113-
if(img_src != undefined && selected.selected == value){
111+
if(img_src !== undefined && selected.selected === value){
114112
var template = html_template.replace('{url}',img_src);
115113

116114
// For multiple selection
@@ -175,32 +173,16 @@
175173
var lis = $(_chosen.chosen.container).find('.chosen-drop ul li')
176174
var options = $(_chosen.chosen.form_field).find('optgroup, option:not(:empty)');
177175

178-
// SS uses a modified Chosen.js and after the 'showing_dropdown' event the
179-
// values get immediatelly reset, also removing the images. Solved it with setTimeout.
180-
181176
for(var i = 0; i < lis.length; i++){
182177
var li = lis[i];
183178
var option = options[i];
184179
var img_src = $(option).attr('data-img-src');
185180

186-
if(typeof img_src != 'undefined' && img_src != ''){
181+
if(typeof img_src !== 'undefined' && img_src !== ''){
187182
var template = html_template.replace('{url}',img_src);
188183
$(li).prepend(template.replace('{class_name}','chose-image-list'));
189184
}
190185
}
191-
192-
/* setTimeout(function(lis, options){
193-
for(var i = 0; i < lis.length; i++){
194-
var li = lis[i];
195-
var option = options[i];
196-
var img_src = $(option).attr('data-img-src');
197-
198-
if(typeof img_src != 'undefined' && img_src != ''){
199-
var template = html_template.replace('{url}',img_src);
200-
$(li).prepend(template.replace('{class_name}','chose-image-list'));
201-
}
202-
}
203-
}, 1, lis, options);*/
204186
});
205187
});
206188
$this.trigger('chosen:hiding_dropdown');

0 commit comments

Comments
 (0)