Skip to content

Commit d23e356

Browse files
committed
added support for empty labels
1 parent 52344cc commit d23e356

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

code/DropdownImageField.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,12 @@ public function Field($properties = array()) {
8686

8787
foreach($source as $item) {
8888
$value = $item->{$this->keyField};
89-
$title = $item->{$this->labelField};
89+
if (empty($this->labelField)) {
90+
$title = '--nbsp';
91+
} else {
92+
$title = $item->{$this->labelField};
93+
}
94+
9095
$image = $item->{$this->imageField}();
9196

9297
$selected = false;

templates/DropdownImageField.ss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<select $AttributesHTML>
22
<% loop $Options %>
3-
<option data-img-src="$Image.Link" value="$Value.XML"<% if $Selected %> selected="selected"<% end_if %><% if $Disabled %> disabled="disabled"<% end_if %>>$Title.XML</option>
3+
<option data-img-src="$Image.Link" value="$Value.XML"<% if $Selected %> selected="selected"<% end_if %><% if $Disabled %> disabled="disabled"<% end_if %>><% if Title == "--nbsp" %>&nbsp;<% else %>$Title.XML<% end_if %></option>
44
<% end_loop %>
55
</select>

0 commit comments

Comments
 (0)