feat: deleting final post should delete the thread

Author: wilr

client/css/Forum.css

@@ -13,9 +13,7 @@
   border: 1px solid var(--color-grey);
 }
 
-.forum__category {
 
-}
 
 /**
  * Admin features at the bottom of the page
@@ -45,7 +43,6 @@
   margin-bottom: 4px;
 }
 
-
 .forum__admin-features .forum__admin-features-title {
   font-size: 14px;
   font-weight: bold;
@@ -54,6 +51,22 @@
   color: var(--color-dark);
 }
 
+.forum__delete-thread-link {
+  display: inline-block;
+  margin-top: 12px;
+  padding: 6px 12px;
+  font-size: 12px;
+  color: #b91c1c;
+  border: 1px solid #b91c1c;
+  border-radius: 4px;
+  text-decoration: none;
+  cursor: pointer;
+}
+
+.forum__delete-thread-link:hover {
+  background-color: #b91c1c;
+  color: #fff;
+}
 
 .forum__subscribe-link--hidden {
   display: none;
@@ -83,21 +96,27 @@
   text-decoration: none;
 }
 
-
 /**
  * Preview content
  */
 .forum__previous-posts {
   margin-bottom: 32px;
   margin-top: 32px;
   padding: 20px;
-  border: 1px dashed var(--color-grey, '#d1d2d6');
+  border: 1px dashed var(--color-grey, "#d1d2d6");
   border-radius: 12px;
 }
-  .forum__previous-posts .forum__post {
-    padding-left: 12px;
-  }
+.forum__previous-posts .forum__post {
+  padding-left: 12px;
+}
 
+.forum__previous-posts h2 {
+  margin-top: 0;
+  margin-bottom: 12px;
+  font-size: 18px;
+  line-height: 24px;
+  color: var(--color-dark);
+}
 
 /**
  * Post list
@@ -114,7 +133,7 @@
 }
 
 .forum__features tbody tr:nth-child(even) {
-  background-color:#f4f4f4;
+  background-color: #f4f4f4;
 }
 
 /**
@@ -160,5 +179,3 @@
   display: flex;
   justify-content: space-between;
 }
-
-

client/javascript/Forum.js

@@ -202,6 +202,25 @@
       });
     });
 
+    /**
+     * Delete Thread link.
+     *
+     * Confirm before deleting the entire thread and all its posts.
+     * Uses native navigation (like ban/ghost) so the server redirect works cleanly.
+     */
+    var deleteThreadLinks = document.querySelectorAll("a.deleteThreadLink");
+    deleteThreadLinks.forEach(function (link) {
+      link.addEventListener("click", function (e) {
+        if (
+          !confirm(
+            "Are you sure you want to delete this entire thread?\nAll posts in this thread will be permanently removed."
+          )
+        ) {
+          e.preventDefault();
+        }
+      });
+    });
+
     /**
      * Ban / Ghost member confirmation
      */

src/Form/PostMessageForm.php

@@ -23,11 +23,13 @@ class PostMessageForm extends Form
 {
     protected ?Post $post = null;
 
+    protected ?ForumThread $thread = null;
+
     public function __construct($controller, $name)
     {
         $fields = FieldList::create([
             TextField::create("Title", _t('Forum.FORUMTHREADTITLE', 'Title')),
-            TextareaField::create("Content", _t('Forum.FORUMREPLYCONTENT', 'Content')),
+            TextareaField::create("Content", _t('Forum.FORUMREPLYCONTENT', 'Message')),
             HiddenField::create('ThreadID', 'ThreadID'),
             HiddenField::create('ID', 'ID'),
             CheckboxField::create(
@@ -50,7 +52,21 @@ public function __construct($controller, $name)
     }
 
 
-    public function setPost(Post $post)
+    public function setThread(?ForumThread $thread = null)
+    {
+        $this->loadDataFrom([
+            'ThreadID' => $thread ? $thread->ID : null,
+            'Title' => $thread ? $thread->Title : null,
+        ]);
+
+        $this->thread = $thread;
+        $this->fields->makeFieldReadonly('Title');
+
+        return $this;
+    }
+
+
+    public function setPost(?Post $post = null)
     {
         $this->loadDataFrom($post);
 

src/PageTypes/Forum.php

@@ -23,7 +23,6 @@
 use SilverStripe\Forms\HeaderField;
 use SilverStripe\Model\List\ArrayList;
 use SilverStripe\Model\List\PaginatedList;
-use SilverStripe\ORM\DB;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Permission;

src/PageTypes/ForumController.php

@@ -7,6 +7,7 @@
 use FullscreenInteractive\SilverStripe\Forum\Form\PostMessageForm;
 use FullscreenInteractive\SilverStripe\Forum\Model\ForumThread;
 use PageController;
+use SilverStripe\Control\Controller;
 use SilverStripe\View\Requirements;
 use FullscreenInteractive\SilverStripe\Forum\Model\ForumThreadSubscription;
 use FullscreenInteractive\SilverStripe\Forum\Model\PostAttachment;
@@ -34,6 +35,7 @@ class ForumController extends PageController
         'AdminFormFeatures',
         'deleteAttachment',
         'deletePost',
+        'deletethread',
         'editpost',
         'markasspam',
         'PostMessageForm',
@@ -265,6 +267,7 @@ public function ban()
         return ($request->isAjax()) ? true : $this->redirectBack();
     }
 
+
     public function ghost()
     {
         $request = $this->getRequest();
@@ -401,6 +404,7 @@ public function filterLanguage(string $content): string
         return $content;
     }
 
+
     /**
      * Get the link for the reply action
      *
@@ -411,6 +415,26 @@ public function ReplyLink()
         return self::join_links($this->Link(), 'reply', $this->urlParams['ID']);
     }
 
+
+    public function reply()
+    {
+        $thread = $this->getForumThread();
+
+        if (!$thread) {
+            return $this->httpError(404);
+        }
+
+        $form = $this->PostMessageForm();
+        $form->setThread($thread);
+
+        return [
+            'Thread' => $thread,
+            'PostMessageForm' => $form,
+            'Title' => DBField::create_field('HTMLText', _t('Forum.REPLYTO', 'Replying to: %s', $thread->Title))
+        ];
+    }
+
+
     /**
      * Show will get the selected thread to the user. Also increments the forums view count.
      */
@@ -576,12 +600,83 @@ public function deletePost()
             return $this->httpError(403);
         }
 
+        $thread = $post->Thread();
         $post->delete();
 
+        $remainingPosts = Post::get()->filter('ThreadID', $thread->ID)->count();
+
+        if ($remainingPosts === 0) {
+            $thread->delete();
+
+            return $this->redirect($this->Link());
+        }
+
         return $this->redirectBack();
     }
 
 
+    /**
+     * Delete an entire thread and all its posts.
+     *
+     * Requires moderator permissions and a valid security token.
+     */
+    public function deletethread()
+    {
+        $request = $this->getRequest();
+
+        if (!SecurityToken::inst()->checkRequest($request)) {
+            return $this->httpError(400);
+        }
+
+        $id = $request->param('ID');
+
+        if (!$id) {
+            return $this->httpError(400);
+        }
+
+        $thread = ForumThread::get()->byID($id);
+
+        if (!$thread) {
+            return $this->httpError(404);
+        }
+
+        if (!$thread->canDelete()) {
+            return $this->httpError(403);
+        }
+
+        $currentUser = Security::getCurrentUser();
+
+        Injector::inst()->get(LoggerInterface::class)->info(sprintf(
+            'Deleted thread "%s" (#%d), by moderator %s (#%d)',
+            $thread->Title,
+            $thread->ID,
+            $currentUser->Email ?? 'Unknown',
+            $currentUser->ID ?? 0
+        ));
+
+        $thread->delete();
+
+        return ($request->isAjax()) ? true : $this->redirect($this->Link());
+    }
+
+
+    /**
+     * Returns a tokenised URL for deleting the current thread, if the user can moderate.
+     */
+    public function DeleteThreadLink(): ?string
+    {
+        $thread = $this->getForumThread();
+
+        if (!$thread || !$thread->canDelete()) {
+            return null;
+        }
+
+        $url = Controller::join_links($this->Link('deletethread'), $thread->ID);
+
+        return SecurityToken::inst()->addToUrl($url);
+    }
+
+
     /**
      * Forum Admin Features form.
      * Handles the dropdown to select the new forum category and the checkbox for stickyness

src/PageTypes/ForumHolderController.php

@@ -11,7 +11,6 @@
 use SilverStripe\Model\List\PaginatedList;
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\View\Requirements;
-use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
 
 class ForumHolderController extends PageController
@@ -27,7 +26,7 @@ class ForumHolderController extends PageController
 
     public function init()
     {
-        Requirements::javascript("fullscreeninteractive/silverstripe-forum:client/javascript/forum.js");
+        Requirements::javascript("fullscreeninteractive/silverstripe-forum:client/javascript/Forum.js");
         Requirements::css("fullscreeninteractive/silverstripe-forum:client/css/Forum.css");
 
         parent::init();

templates/FullscreenInteractive/SilverStripe/Forum/PageTypes/Layout/Forum_reply.ss

@@ -3,13 +3,18 @@
 $PostMessageForm
 
 <div id="forum__previous-posts" class="forum__previous-posts">
+    <h2>Replying to: $Topic.Title</h2>
+
     <ul id="forum__posts" class="forum__posts">
-        <% loop $Posts('DESC') %>
+        <% loop $Posts('DESC').Limit(3) %>
             <li class="$EvenOdd">
                 <% include SinglePost %>
             </li>
         <% end_loop %>
     </ul>
+        <p>
+        <a href="{$Thread.Link}" class="btn btn-secondary" target="_blank">View topic</a>
+    </p>
 </div>
 
 <% include ForumFooter %>

templates/FullscreenInteractive/SilverStripe/Forum/PageTypes/Layout/Forum_show.ss

@@ -83,6 +83,10 @@
 <div class="forum__admin-features">
     <h3 class="forum__admin-features-title">Forum Admin Features</h3>
     $AdminFormFeatures
+
+    <% if $DeleteThreadLink %>
+        <a href="$DeleteThreadLink" class="forum__delete-thread-link deleteThreadLink"><%t Forum.DELETETHREAD "Delete Thread" %></a>
+    <% end_if %>
 </div>
 <% end_if %>