If inline save disabled then don't add buttton

Author: wilr

client/js/ManyField.src.js

@@ -12,11 +12,14 @@
         $(elem).find('.manyfield__row').each(function (r, row) {
           if (canRemove) {
             if (!$(row).find('.manyfield__remove').length) {
-              var href = $(this).data('inline-save').replace('saveRecord', 'deleteRecord');
+              var href = $(this).data('inline-save');
 
-              href = href + '?ID='+ $(row).find('[name=ID]').val();
+              if (href) {
+                href.replace('saveRecord', 'deleteRecord');
+                href = href + '?ID='+ $(row).find('[name=ID]').val();
 
-              $(row).prepend('<a class="btn btn-sm btn-danger manyfield__remove" href="' + href + '"><i class="fa fa-times"></i></a>');
+                $(row).prepend('<a class="btn btn-sm btn-danger manyfield__remove" href="' + href + '"><i class="fa fa-times"></i></a>');
+              }
             }
           } else {
             field.find('.manyfield__remove').remove();

src/ManyField.php

@@ -14,6 +14,7 @@
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Control\HTTPResponse;
 use Exception;
+use SilverStripe\ORM\SS_List;
 
 class ManyField extends CompositeField
 {
@@ -379,15 +380,19 @@ public function saveRecord()
             $class = $this->value->dataClass();
         }
 
-        if (!$index || !$class) {
-            throw new Exception('saveRecord() must be passed an ID and ClassName');
+        if (!$class) {
+            throw new Exception('saveRecord() must be passed a ClassName');
         }
 
         if ($this->manyFieldDataClass && $class !== $this->manyFieldDataClass) {
             throw new Exception('Invalid ClassName passed');
         }
 
-        $record = $class::get()->byId($index);
+        if (!$index) {
+            $record = $class::create();
+        } else {
+            $record = $class::get()->byId($index);
+        }
 
         if (!$record || !$record->canEdit()) {
             return Controller::curr()->httpError(400);
@@ -649,10 +654,17 @@ public function generateRow($index, $value = null, $prefixName = true)
 
     public function createPhysicalRecord()
     {
-        $create = Injector::inst()->create($this->value->dataClass());
+        if ($this->manyFieldDataClass) {
+            $create = Injector::inst()->create($this->manyFieldDataClass);
+        } else {
+            $create = Injector::inst()->create($this->value->dataClass());
+        }
+
         $create->write();
 
-        $this->value->add($create);
+        if ($this->value instanceof SS_List) {
+            $this->value->add($create);
+        }
 
         return $create;
     }
@@ -675,6 +687,7 @@ public function updateRelation(DataObjectInterface $record, $delete = true)
         }
 
         $existing = $record->{$this->name}();
+
         // if no value then we should clear everything out
         if (!$this->value && $this->canRemove) {
             if ($delete) {
@@ -713,6 +726,8 @@ public function updateRelation(DataObjectInterface $record, $delete = true)
             }
         }
 
+        $updatedData = [];
+
         foreach ($this->value as $col => $values) {
             if ($col == 'ID') {
                 continue;