Skip to content

Commit 2facfa7

Browse files
committed
Display messages on form field
1 parent eda092f commit 2facfa7

File tree

9 files changed

+79
-40
lines changed

9 files changed

+79
-40
lines changed

client/dist/js/queuedjobprogressfield.js

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/dist/js/queuedjobprogressfield.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/dist/styles/queuedjobprogressfield.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/dist/styles/queuedjobprogressfield.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/src/bundles/queuedjobprogressfield.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
// import 'bootstrap';
2-
32
window.jQuery.entwine('ss', ($) => {
43
$('.queuedjob__progress').entwine({
54
onmatch() {
@@ -71,6 +70,8 @@ window.jQuery.entwine('ss', ($) => {
7170
$('body').trigger('queuedjob-finished')
7271
}
7372

73+
$(self).find('.messages').val(resp.Messages);
74+
7475
if (changed) {
7576
progress.popover('hide').popover('dispose')
7677

@@ -83,6 +84,8 @@ window.jQuery.entwine('ss', ($) => {
8384
.attr('data-content', resp.Content)
8485

8586
progress.popover('show')
87+
} else {
88+
progress.popover('show');
8689
}
8790

8891
if (resp.Status !== 'bg-success') {

client/src/styles/queuedjobprogressfield.scss

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,28 @@
1818
.arrow {
1919
display: none;
2020
}
21+
22+
.messages {
23+
height: 120px;
24+
padding: 15px;
25+
width: 100%;
26+
background: #eee;
27+
box-shadow: inset 0 4px rgba(0, 0, 0, 0.2);
28+
border-radius: 4px;
29+
margin: 10px 0;
30+
overflow: scroll;
31+
32+
ul {
33+
margin: 0;
34+
padding: 0 0 0 15px;
35+
}
36+
37+
li {
38+
font-size: 12px;
39+
font-family: monospace;
40+
line-height: 15px;
41+
color: #333;
42+
margin: 0;
43+
}
44+
}
2145
}

src/QueuedJobProgressField.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,9 @@ public function jobProgress()
115115
'Content' => $this->getPopoverContent(),
116116
'Percentage' => $this->getPercentage(),
117117
'Status' => $this->getStatus(),
118-
'StatusCode' => $this->getJob()->JobStatus,
119-
'Animated' => $this->isAnimated()
118+
'StatusCode' => $job->JobStatus,
119+
'Animated' => $this->isAnimated(),
120+
'Messages' => (is_object($job->getMessages())) ? $job->getMessages()->CDATA() : 'Job Log..'
120121
]);
121122
} else {
122123
return $this->httpError(400);
@@ -161,6 +162,10 @@ public function getPercentage()
161162
$completed = $this->getCompletedSteps();
162163
$total = $this->getTotalSteps();
163164

165+
if ($completed >= $total) {
166+
return '100';
167+
}
168+
164169
if ($total < 1) {
165170
return '5'; // minimum 5% width
166171
}

templates/FullscreenInteractive/QueuedJobProgressField/QueuedJobProgressController.ss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@
5050
opacity: 0.3;
5151
}
5252

53+
.fas {
54+
margin-top: 2px;
55+
}
56+
5357
.progress--meta {
5458
opacity: 0.7;
5559
padding-left: 70px;
@@ -103,10 +107,6 @@
103107
padding: 0 0 0 70px;
104108
border: none;
105109
}
106-
107-
#QueuedJobProgressField {
108-
padding: 100px 0 0;
109-
}
110110
</style>
111111

112112
<script>
@@ -148,7 +148,7 @@
148148
</div>
149149

150150
<div class="progress--meta">
151-
<p>Job started by $CurrentJob.RunAs.Name at {$CurrentJob.Created.Nice}</p>
151+
<p>Job #$CurrentJob.ID started by $CurrentJob.RunAs.Name at {$CurrentJob.Created.Nice}</p>
152152
</div>
153153

154154
$ProgressForm
Lines changed: 32 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,35 @@
1-
<% if Job %>
2-
<div class="queuedjob__progress progress" data-live="{$Link(jobProgress)}?JobId=$Job.ID&amp;JobSignature=$Job.Signature" data-interval="$CheckInterval">
3-
<div
4-
class="progress-bar progress-bar-striped $Status <% if isAnimated %>progress-bar-animated<% end_if %>"
5-
role="progressbar"
6-
data-placement="top"
7-
aria-valuenow="$CompletedSteps"
8-
style="width: {$Percentage}%"
9-
aria-valuemin="0"
10-
aria-valuemax="$TotalSteps"
11-
title="$PopoverTitle"
12-
data-content="$PopoverContent">
1+
<div class="queuedjobprogress">
2+
<% if Job %>
3+
<div class="queuedjob__progress progress" data-live="{$Link(jobProgress)}?JobId=$Job.ID&amp;JobSignature=$Job.Signature" data-interval="$CheckInterval">
4+
<div
5+
class="progress-bar progress-bar-striped $Status <% if isAnimated %>progress-bar-animated<% end_if %>"
6+
role="progressbar"
7+
data-placement="top"
8+
aria-valuenow="$CompletedSteps"
9+
style="width: {$Percentage}%"
10+
aria-valuemin="0"
11+
aria-valuemax="$TotalSteps"
12+
title="$PopoverTitle"
13+
data-content="$PopoverContent">
14+
</div>
1315
</div>
14-
</div>
1516

16-
<small style="margin-top: 20px; display: block;"><a href="admin/queuedjobs/Symbiote-QueuedJobs-DataObjects-QueuedJobDescriptor/EditForm/field/QueuedJobDescriptor/item/$ID/edit" style="color: #999">View Job Information</a></small>
17-
<% else %>
18-
<div class="queuedjob__progress progress" data-live="" data-interval="0">
19-
<div
20-
class="progress-bar progress-bar-striped"
21-
role="progressbar"
22-
data-placement="top"
23-
aria-valuenow="0"
24-
style="width: 0%"
25-
aria-valuemin="0"
26-
aria-valuemax="1"
27-
title="No Job Found"
28-
data-content="Cannot find scheduled job">
17+
<small style="margin-top: 20px; display: block;"><a href="admin/queuedjobs/Symbiote-QueuedJobs-DataObjects-QueuedJobDescriptor/EditForm/field/QueuedJobDescriptor/item/$ID/edit" style="color: #999">View Job Information</a></small>
18+
19+
<div class="messages" class="messages">$Job.Messages</div>
20+
<% else %>
21+
<div class="queuedjob__progress progress" data-live="" data-interval="0">
22+
<div
23+
class="progress-bar progress-bar-striped"
24+
role="progressbar"
25+
data-placement="top"
26+
aria-valuenow="0"
27+
style="width: 0%"
28+
aria-valuemin="0"
29+
aria-valuemax="1"
30+
title="No Job Found"
31+
data-content="Cannot find scheduled job">
32+
</div>
2933
</div>
30-
</div>
31-
<% end_if %>
34+
<% end_if %>
35+
</div>

0 commit comments

Comments
 (0)