Skip to content

Commit 082eaf8

Browse files
authored
Merge pull request #52 from fullstack-devops/bugfix/fix-asset-names-to-upload
Bugfix/fix asset names to upload
2 parents a048c8d + 62e83fd commit 082eaf8

File tree

4 files changed

+144
-7
lines changed

4 files changed

+144
-7
lines changed

.github/workflows/Release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
# env:
7474
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7575

76-
create_release_test:
76+
publish_release:
7777
runs-on: ubuntu-latest
7878
needs: [generate_infos, build]
7979
steps:
@@ -90,7 +90,7 @@ jobs:
9090
path: out/
9191
key: awesome-ci-${{ github.sha }}
9292

93-
- name: Create Release
93+
- name: Publish Release
9494
run: awesome-ci release publish -releaseid "$ACI_RELEASE_ID" -upload "file=out/$ARTIFACT1,file=out/$ARTIFACT2"
9595
env:
9696
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

docs/CODE_OF_CONDUCT.md

Lines changed: 128 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,128 @@
1+
# Contributor Covenant Code of Conduct
2+
3+
## Our Pledge
4+
5+
We as members, contributors, and leaders pledge to make participation in our
6+
community a harassment-free experience for everyone, regardless of age, body
7+
size, visible or invisible disability, ethnicity, sex characteristics, gender
8+
identity and expression, level of experience, education, socio-economic status,
9+
nationality, personal appearance, race, religion, or sexual identity
10+
and orientation.
11+
12+
We pledge to act and interact in ways that contribute to an open, welcoming,
13+
diverse, inclusive, and healthy community.
14+
15+
## Our Standards
16+
17+
Examples of behavior that contributes to a positive environment for our
18+
community include:
19+
20+
* Demonstrating empathy and kindness toward other people
21+
* Being respectful of differing opinions, viewpoints, and experiences
22+
* Giving and gracefully accepting constructive feedback
23+
* Accepting responsibility and apologizing to those affected by our mistakes,
24+
and learning from the experience
25+
* Focusing on what is best not just for us as individuals, but for the
26+
overall community
27+
28+
Examples of unacceptable behavior include:
29+
30+
* The use of sexualized language or imagery, and sexual attention or
31+
advances of any kind
32+
* Trolling, insulting or derogatory comments, and personal or political attacks
33+
* Public or private harassment
34+
* Publishing others' private information, such as a physical or email
35+
address, without their explicit permission
36+
* Other conduct which could reasonably be considered inappropriate in a
37+
professional setting
38+
39+
## Enforcement Responsibilities
40+
41+
Community leaders are responsible for clarifying and enforcing our standards of
42+
acceptable behavior and will take appropriate and fair corrective action in
43+
response to any behavior that they deem inappropriate, threatening, offensive,
44+
or harmful.
45+
46+
Community leaders have the right and responsibility to remove, edit, or reject
47+
comments, commits, code, wiki edits, issues, and other contributions that are
48+
not aligned to this Code of Conduct, and will communicate reasons for moderation
49+
decisions when appropriate.
50+
51+
## Scope
52+
53+
This Code of Conduct applies within all community spaces, and also applies when
54+
an individual is officially representing the community in public spaces.
55+
Examples of representing our community include using an official e-mail address,
56+
posting via an official social media account, or acting as an appointed
57+
representative at an online or offline event.
58+
59+
## Enforcement
60+
61+
Instances of abusive, harassing, or otherwise unacceptable behavior may be
62+
reported to the community leaders responsible for enforcement at
63+
FsOps.
64+
All complaints will be reviewed and investigated promptly and fairly.
65+
66+
All community leaders are obligated to respect the privacy and security of the
67+
reporter of any incident.
68+
69+
## Enforcement Guidelines
70+
71+
Community leaders will follow these Community Impact Guidelines in determining
72+
the consequences for any action they deem in violation of this Code of Conduct:
73+
74+
### 1. Correction
75+
76+
**Community Impact**: Use of inappropriate language or other behavior deemed
77+
unprofessional or unwelcome in the community.
78+
79+
**Consequence**: A private, written warning from community leaders, providing
80+
clarity around the nature of the violation and an explanation of why the
81+
behavior was inappropriate. A public apology may be requested.
82+
83+
### 2. Warning
84+
85+
**Community Impact**: A violation through a single incident or series
86+
of actions.
87+
88+
**Consequence**: A warning with consequences for continued behavior. No
89+
interaction with the people involved, including unsolicited interaction with
90+
those enforcing the Code of Conduct, for a specified period of time. This
91+
includes avoiding interactions in community spaces as well as external channels
92+
like social media. Violating these terms may lead to a temporary or
93+
permanent ban.
94+
95+
### 3. Temporary Ban
96+
97+
**Community Impact**: A serious violation of community standards, including
98+
sustained inappropriate behavior.
99+
100+
**Consequence**: A temporary ban from any sort of interaction or public
101+
communication with the community for a specified period of time. No public or
102+
private interaction with the people involved, including unsolicited interaction
103+
with those enforcing the Code of Conduct, is allowed during this period.
104+
Violating these terms may lead to a permanent ban.
105+
106+
### 4. Permanent Ban
107+
108+
**Community Impact**: Demonstrating a pattern of violation of community
109+
standards, including sustained inappropriate behavior, harassment of an
110+
individual, or aggression toward or disparagement of classes of individuals.
111+
112+
**Consequence**: A permanent ban from any sort of public interaction within
113+
the community.
114+
115+
## Attribution
116+
117+
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
118+
version 2.0, available at
119+
https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
120+
121+
Community Impact Guidelines were inspired by [Mozilla's code of conduct
122+
enforcement ladder](https://github.com/mozilla/diversity).
123+
124+
[homepage]: https://www.contributor-covenant.org
125+
126+
For answers to common questions about this code of conduct, see the FAQ at
127+
https://www.contributor-covenant.org/faq. Translations are available at
128+
https://www.contributor-covenant.org/translations.

src/acigithub/release.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,17 +93,17 @@ func PublishRelease(version string, releaseId int64, uploadArtifacts *string) (e
9393
}
9494

9595
for _, fileAndInfo := range filesAndInfos {
96-
fmt.Printf("uploading %s as asset to release", fileAndInfo.Name())
96+
fmt.Printf("uploading %s as asset to release", fileAndInfo.Name)
9797
// Upload assets to GitHub Release
9898
_, _, err := GithubClient.Repositories.UploadReleaseAsset(
9999
ctx,
100100
owner,
101101
repo,
102102
releaseId,
103103
&github.UploadOptions{
104-
Name: fileAndInfo.Name(),
104+
Name: fileAndInfo.Name,
105105
},
106-
&fileAndInfo)
106+
&fileAndInfo.File)
107107
if err != nil {
108108
log.Println("error at uploading asset to release: ", err)
109109
}

src/tools/tools.go

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,12 @@ import (
77
"strings"
88
)
99

10-
func GetFilesAndInfos(uploadArtifacts *string) (files []os.File, err error) {
10+
type UploadArtifact struct {
11+
File os.File
12+
Name string
13+
}
14+
15+
func GetFilesAndInfos(uploadArtifacts *string) (artifacts []UploadArtifact, err error) {
1116
artifactsToUpload := strings.Split(*uploadArtifacts, ",")
1217
for _, artifact := range artifactsToUpload {
1318
var sanFilename string
@@ -18,7 +23,11 @@ func GetFilesAndInfos(uploadArtifacts *string) (files []os.File, err error) {
1823
if err != nil {
1924
return nil, err
2025
}
21-
files = append(files, *file)
26+
info, _ := file.Stat()
27+
artifacts = append(artifacts, UploadArtifact{
28+
File: *file,
29+
Name: info.Name(),
30+
})
2231
}
2332
return
2433
}

0 commit comments

Comments
 (0)